Signed settings refactoring: Proper caching and more tests.

chrome/browser/policy/device_policy_cache.h

Index: chrome/browser/policy/device_policy_cache.h
diff --git a/chrome/browser/policy/device_policy_cache.h b/chrome/browser/policy/device_policy_cache.h
index 63ed1cedf2dfe8bf9d905f1ba6b142daa7a91659..0dbe4ed4ddf67be04b284fb8324686abdaf34081 100644
--- a/chrome/browser/policy/device_policy_cache.h
+++ b/chrome/browser/policy/device_policy_cache.h
@@ -22,8 +22,7 @@ namespace em = enterprise_management;
 
 // CloudPolicyCacheBase implementation that persists policy information
 // to ChromeOS' session manager (via SignedSettingsHelper).
-class DevicePolicyCache : public CloudPolicyCacheBase,
-                          public chromeos::SignedSettingsHelper::Callback {
+class DevicePolicyCache : public CloudPolicyCacheBase {
  public:
   DevicePolicyCache(CloudPolicyDataStore* data_store,
                     EnterpriseInstallAttributes* install_attributes);
@@ -34,8 +33,7 @@ class DevicePolicyCache : public CloudPolicyCacheBase,
   virtual void SetPolicy(const em::PolicyFetchResponse& policy) OVERRIDE;
   virtual void SetUnmanaged() OVERRIDE;
 
-  // SignedSettingsHelper::Callback implementation:
-  virtual void OnRetrievePolicyCompleted(
+  void OnRetrievePolicyCompleted(
       chromeos::SignedSettings::ReturnCode code,
       const em::PolicyFetchResponse& policy) OVERRIDE;

[Mattias Nissler (ping if slow), 2011/11/30 12:25:50]

this is no longer an override.

[pastarmovj, 2011/11/30 17:21:16]

Yeah clang already told me so :)