Signed settings refactoring: Proper caching and more tests.

chrome/browser/chromeos/login/wizard_controller.cc

Index: chrome/browser/chromeos/login/wizard_controller.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc
index 693712deb0f1a81bd327103ca2491d0616dbf50b..6acc503aef45c59a119e98b08e251c7cc1b2cce2 100644
--- a/chrome/browser/chromeos/login/wizard_controller.cc
+++ b/chrome/browser/chromeos/login/wizard_controller.cc
@@ -18,6 +18,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/cryptohome_library.h"
+#include "chrome/browser/chromeos/cros_settings.h"
 #include "chrome/browser/chromeos/cros_settings_names.h"
 #include "chrome/browser/chromeos/customization_document.h"
 #include "chrome/browser/chromeos/language_preferences.h"
@@ -31,7 +32,6 @@
 #include "chrome/browser/chromeos/login/network_screen.h"
 #include "chrome/browser/chromeos/login/oobe_display.h"
 #include "chrome/browser/chromeos/login/registration_screen.h"
-#include "chrome/browser/chromeos/login/signed_settings_temp_storage.h"
 #include "chrome/browser/chromeos/login/update_screen.h"
 #include "chrome/browser/chromeos/login/user_image_screen.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
@@ -382,11 +382,13 @@ void WizardController::OnEulaAccepted() {
   // But we can at least create the consent file and Chrome would port that
   // if the device is owned by a local user. In case of enterprise enrolled
   // device the setting will be respected only until the policy is not set.
-  base::FundamentalValue value(usage_statistics_reporting_);
-  SignedSettingsTempStorage::Store(
+  CrosSettings::Get()->SetBoolean(kStatsReportingPref,
+                                  usage_statistics_reporting_);
+/*  base::FundamentalValue value(usage_statistics_reporting_);
+  SignedSettingsCache::Store(
       kStatsReportingPref,
       value,
-      g_browser_process->local_state());
+      g_browser_process->local_state());*/

[Mattias Nissler (ping if slow), 2011/11/30 12:25:50]

commented out? why?

[pastarmovj, 2011/11/30 17:21:16]

Fixed this whole bunch of code I kind of forgot to pimp it while doing the rest.

   bool enabled =
       OptionsUtil::ResolveMetricsReportingEnabled(usage_statistics_reporting_);
   // Make sure the local state cached value is updated too because the real