chrome/chrome_browser.gypi - Issue 8727037: Signed settings refactoring: Proper caching and more tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 8727037: Signed settings refactoring: Proper caching and more tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed second round of comments and fixed a mem leak in one of the new tests. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 3792350625fdbca24e60d082fa3376162df4d9bf..60b23c5247022f67a79a61a2155155ff73ace266 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -632,8 +632,8 @@

'browser/chromeos/login/signed_settings.h',

'browser/chromeos/login/signed_settings_helper.cc',

'browser/chromeos/login/signed_settings_helper.h',

- 'browser/chromeos/login/signed_settings_temp_storage.cc',

- 'browser/chromeos/login/signed_settings_temp_storage.h',

+ 'browser/chromeos/login/signed_settings_cache.cc',

+ 'browser/chromeos/login/signed_settings_cache.h',

'browser/chromeos/login/take_photo_view.cc',

'browser/chromeos/login/take_photo_view.h',

'browser/chromeos/login/test_attempt_state.cc',

@@ -737,6 +737,8 @@

'browser/chromeos/setting_level_bubble.h',

'browser/chromeos/setting_level_bubble_view.cc',

'browser/chromeos/setting_level_bubble_view.h',

+ 'browser/chromeos/signed_settings_migration_helper.cc',

+ 'browser/chromeos/signed_settings_migration_helper.h',

'browser/chromeos/sim_dialog_delegate.cc',

'browser/chromeos/sim_dialog_delegate.h',

'browser/chromeos/sms_observer.cc',

@@ -793,8 +795,8 @@

'browser/chromeos/tab_closeable_state_watcher.h',

'browser/chromeos/upgrade_detector_chromeos.cc',

'browser/chromeos/upgrade_detector_chromeos.h',

- 'browser/chromeos/user_cros_settings_provider.cc',

- 'browser/chromeos/user_cros_settings_provider.h',

+ 'browser/chromeos/device_settings_provider.cc',

+ 'browser/chromeos/device_settings_provider.h',

'browser/chromeos/version_loader.cc',

'browser/chromeos/version_loader.h',

'browser/chromeos/view_ids.h',