chrome/browser/policy/enterprise_metrics_browsertest.cc - Issue 8727037: Signed settings refactoring: Proper caching and more tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/enterprise_metrics_browsertest.cc

Issue 8727037: Signed settings refactoring: Proper caching and more tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed second round of comments and fixed a mem leak in one of the new tests. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/enterprise_metrics_browsertest.cc

diff --git a/chrome/browser/policy/enterprise_metrics_browsertest.cc b/chrome/browser/policy/enterprise_metrics_browsertest.cc

index 2c596f1432293d31c1802da973f7bd13dd24661f..8f35caadc54faaedde42e9c65d279c3c89234edc 100644

--- a/chrome/browser/policy/enterprise_metrics_browsertest.cc

+++ b/chrome/browser/policy/enterprise_metrics_browsertest.cc

@@ -695,9 +695,6 @@ class DevicePolicyCacheTestHelper {

install_attributes_.ExpectUsage();

EXPECT_CALL(mock_signed_settings_helper_, StartStorePolicyOp(_, _))

.WillOnce(MockSignedSettingsHelperStorePolicy(code));

- EXPECT_CALL(mock_signed_settings_helper_, CancelCallback(_))

- .Times(1)

- .RetiresOnSaturation();

EXPECT_CALL(mock_signed_settings_helper_,

StartRetrievePolicyOp(_)).Times(expected_retrieves);

}

@@ -713,7 +710,6 @@ class DevicePolicyCacheTestHelper {

install_attributes_.install_attributes(),

&mock_signed_settings_helper_));

data_store_->SetupForTesting("", "id", "user", "gaia_token", false);

- EXPECT_CALL(mock_signed_settings_helper_, CancelCallback(_)).Times(1);

}

chromeos::MockSignedSettingsHelper mock_signed_settings_helper_;