Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10130)

Unified Diff: chrome/browser/chromeos/login/session_manager_observer.cc

Issue 8727037: Signed settings refactoring: Proper caching and more tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed second round of comments and fixed a mem leak in one of the new tests. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/session_manager_observer.cc
diff --git a/chrome/browser/chromeos/login/session_manager_observer.cc b/chrome/browser/chromeos/login/session_manager_observer.cc
index b4401be2d0b73aa343162e31ac91170a0f3a0d70..91ff4f8f3074a0050cb7dd8b6a5ab941eac0613e 100644
--- a/chrome/browser/chromeos/login/session_manager_observer.cc
+++ b/chrome/browser/chromeos/login/session_manager_observer.cc
@@ -6,7 +6,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/login/signed_settings.h"
-#include "chrome/browser/chromeos/login/signed_settings_temp_storage.h"
+#include "chrome/browser/chromeos/login/signed_settings_cache.h"
#include "chrome/common/chrome_notification_types.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
@@ -59,13 +59,6 @@ void SessionManagerObserver::OwnerKeySet(bool success) {
result,
content::NotificationService::AllSources(),
content::NotificationService::NoDetails());
-
- // We stored some settings in transient storage before owner was assigned.
- // Now owner is assigned and key is generated and we should persist
- // those settings into signed storage.
- if (g_browser_process && g_browser_process->local_state()) {
- SignedSettingsTempStorage::Finalize(g_browser_process->local_state());
- }
}
void SessionManagerObserver::PropertyChangeComplete(bool success) {

Powered by Google App Engine
This is Rietveld 408576698