Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/chromeos/login/mock_signed_settings_helper.h

Issue 8727037: Signed settings refactoring: Proper caching and more tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed second round of comments and fixed a mem leak in one of the new tests. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/mock_signed_settings_helper.h
diff --git a/chrome/browser/chromeos/login/mock_signed_settings_helper.h b/chrome/browser/chromeos/login/mock_signed_settings_helper.h
index 628b5527fd4b88390c9c816e195608c9c2bc9bc4..162fed15bb8aa5c48698b36aae0d0f971023bc09 100644
--- a/chrome/browser/chromeos/login/mock_signed_settings_helper.h
+++ b/chrome/browser/chromeos/login/mock_signed_settings_helper.h
@@ -17,25 +17,22 @@ class MockSignedSettingsHelper : public chromeos::SignedSettingsHelper {
MockSignedSettingsHelper();
virtual ~MockSignedSettingsHelper();
- MOCK_METHOD3(StartStorePropertyOp,
- void(const std::string&, const base::Value&, Callback*));
- MOCK_METHOD2(StartRetrieveProperty,
- void(const std::string&, Callback*));
MOCK_METHOD2(StartStorePolicyOp,
- void(const em::PolicyFetchResponse&, Callback*));
- MOCK_METHOD1(StartRetrievePolicyOp, void(Callback* callback));
- MOCK_METHOD1(CancelCallback, void(Callback*));
+ void(const em::PolicyFetchResponse&,
+ SignedSettingsHelper::StorePolicyCallback));
+ MOCK_METHOD1(StartRetrievePolicyOp,
+ void(SignedSettingsHelper::RetrievePolicyCallback));
private:
DISALLOW_COPY_AND_ASSIGN(MockSignedSettingsHelper);
};
ACTION_P(MockSignedSettingsHelperStorePolicy, status_code) {
- arg1->OnStorePolicyCompleted(status_code);
+ arg1.Run(status_code);
}
ACTION_P2(MockSignedSettingsHelperRetrievePolicy, status_code, policy) {
- arg0->OnRetrievePolicyCompleted(status_code, policy);
+ arg0.Run(status_code, policy);
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698