Signed settings refactoring: Proper caching and more tests.

chrome/browser/chromeos/cros_settings.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 74 matching lines @@
   // If the pref at the given path changes, we call the observer's Observe
   // method with PREF_CHANGED.
   void AddSettingsObserver(const char* path,
                            content::NotificationObserver* obs);
   void RemoveSettingsObserver(const char* path,
                               content::NotificationObserver* obs);
 
   // Returns the provider that handles settings with the path or prefix.
   CrosSettingsProvider* GetProvider(const std::string& path) const;
 
+  // Forces all providers to reload their caches from the respective backing
+  // stores if they have any.
+  void ReloadProviders() const;

[Denis Lagno, 2011/12/01 00:38:12]

just wondering why is should be const?

[pastarmovj, 2011/12/01 10:07:17]

No special reason but it doesn't change the internal state of this class so I
decided to mark it as such.

+
  private:
   // List of ChromeOS system settings providers.
   std::vector<CrosSettingsProvider*> providers_;
 
   // A map from settings names to a list of observers. Observers get fired in
   // the order they are added.
   typedef ObserverList<content::NotificationObserver> NotificationObserverList;
   typedef base::hash_map<std::string, NotificationObserverList*>
       SettingsObserverMap;
   SettingsObserverMap settings_observers_;
 
   CrosSettings();
   ~CrosSettings();
   friend struct base::DefaultLazyInstanceTraits<CrosSettings>;
 
   DISALLOW_COPY_AND_ASSIGN(CrosSettings);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_