Signed settings refactoring: Proper caching and more tests.

chrome/browser/ui/webui/options/chromeos/system_settings_provider.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 10 matching lines @@
 
 namespace chromeos {
 
 class SystemSettingsProvider : public CrosSettingsProvider,
                                public system::TimezoneSettings::Observer {
  public:
   SystemSettingsProvider();
   virtual ~SystemSettingsProvider();
 
   // CrosSettingsProvider overrides.
-  virtual const base::Value* Get(const std::string& path) const OVERRIDE;
+  virtual base::Value* Get(const std::string& path) const OVERRIDE;
   virtual bool GetTrusted(const std::string& path,
-                          const base::Closure& callback) const OVERRIDE;
+                          const base::Closure& callback) OVERRIDE;
   virtual bool HandlesSetting(const std::string& path) const OVERRIDE;
+  virtual void Reload() OVERRIDE;
 
   // Overridden from TimezoneSettings::Observer:
   virtual void TimezoneChanged(const icu::TimeZone& timezone) OVERRIDE;
 
   // Creates the map of timezones used by the options page.
   base::ListValue* GetTimezoneList();
 
  private:
   // CrosSettingsProvider overrides.
   virtual void DoSet(const std::string& path,
@@ skipping 12 matching lines @@
   // rule of given |timezone|.
   // One timezone could have multiple timezones,
   // e.g.
   //   US/Pacific == America/Los_Angeles
   // We should always use the known timezone id when passing back as
   // pref values.
   string16 GetKnownTimezoneID(const icu::TimeZone& timezone) const;
 
   // Timezones.
   std::vector<icu::TimeZone*> timezones_;
-  // TODO(pastarmovj): This will be cached in the local_state PrefStore soon.
-  mutable scoped_ptr<base::StringValue> system_timezone_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemSettingsProvider);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_