chrome/browser/resources/file_manager/mediaplayer.html - Issue 8727028: Eliminate use of assignments to innerHTML in File Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/mediaplayer.html

Issue 8727028: Eliminate use of assignments to innerHTML in File Browser (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/file_manager/mediaplayer.html

diff --git a/chrome/browser/resources/file_manager/mediaplayer.html b/chrome/browser/resources/file_manager/mediaplayer.html

index 00caf24742ebceade4dd5c3535b46972720c1079..0915f8fb9098e77ff0724dcb2b9b3e1dabedae27 100644

--- a/chrome/browser/resources/file_manager/mediaplayer.html

+++ b/chrome/browser/resources/file_manager/mediaplayer.html

@@ -603,7 +603,9 @@ HidingControlsAnimation.prototype = {

function setupPlaybackControls() {

var element = $('playercontrols');

- playercontrols.innerHTML = ''; // clear out other

+ while (playercontrols.firstChild) {

+ playercontrols.removeChild(playercontrols.firstChild);

+ }

var controlsclass = '';

if (hidingControlsAnimation) {

hidingControlsAnimation.cleanup();