Eliminate use of assignments to innerHTML in File Browser

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 416 matching lines @@
       }, opt_errorCallback);
     }
   }
 
   function isSystemDirEntry(dirEntry) {
     return dirEntry.fullPath == '/' ||
         dirEntry.fullPath == REMOVABLE_DIRECTORY ||
         dirEntry.fullPath == ARCHIVE_DIRECTORY;
   }
 
+  function removeChildren(element) {

[arv (Not doing code reviews), 2011/11/29 22:53:27]

element.textContent = '';

+    while (element.firstChild) {
+      element.removeChild(element.firstChild);
+    }
+  };
+
   // Public statics.
 
   /**
    * List of dialog types.
    *
    * Keep this in sync with FileManagerDialog::GetDialogTypeAsString, except
    * FULL_PAGE which is specific to this code.
    *
    * @enum {string}
    */
@@ skipping 1374 matching lines @@
       urls: [],
       totalCount: 0,
       fileCount: 0,
       directoryCount: 0,
       bytes: 0,
       iconType: null,
       indexes: this.currentList_.selectionModel.selectedIndexes
     };
 
     this.previewSummary_.textContent = str('COMPUTING_SELECTION');
-    this.taskButtons_.innerHTML = '';
-    this.previewThumbnails_.innerHTML = '';
+    removeChildren(this.taskButtons_);
+    removeChildren(this.previewThumbnails_);
 
     if (!selection.indexes.length) {
       this.updateCommonActionButtons_();
       this.updatePreviewPanelVisibility_();
       cr.dispatchSimpleEvent(this, 'selection-summarized');
       return;
     }
 
     var fileCount = 0;
     var byteCount = 0;
@@ skipping 63 matching lines @@
       }
 
       if (pendingFiles.length) {
         cacheEntrySize(pendingFiles.pop(), cacheNextFile);
       } else {
         self.dispatchEvent(new cr.Event('selection-summarized'));
       }
     }
 
     if (this.dialogType_ == FileManager.DialogType.FULL_PAGE) {
-      this.taskButtons_.innerHTML = '';
+      removeChildren(this.taskButtons_);
       // Some internal tasks cannot be defined in terms of file patterns,
       // so we pass selection to check for them manually.
       if (selection.directoryCount == 0 && selection.fileCount > 0) {
         // Only files, not directories, are supported for external tasks.
         chrome.fileBrowserPrivate.getFileTasks(
             selection.urls,
             this.onTasksFound_.bind(this, selection));
       } else {
         // There may be internal tasks for directories.
         this.onTasksFound_(selection, []);
@@ skipping 135 matching lines @@
     this.metadataProvider_ = new TestAwareMetadataProvider();
   };
 
   /**
    * Callback called when tasks for selected files are determined.
    * @param {Object} selection Selection is passed here, since this.selection
    *     can change before tasks were found, and we should be accurate.
    * @param {Array.<Task>} tasksList The tasks list.
    */
   FileManager.prototype.onTasksFound_ = function(selection, tasksList) {
-    this.taskButtons_.innerHTML = '';
+    removeChildren(this.taskButtons_);
 
     for (var i = 0; i < tasksList.length; i++) {
       var task = tasksList[i];
 
       // Tweak images, titles of internal tasks.
       var task_parts = task.taskId.split('|');
       if (task_parts[0] == this.getExtensionId_()) {
         task.internal = true;
         if (task_parts[1] == 'preview') {
           // TODO(serya): This hack needed until task.iconUrl get working
@@ skipping 299 matching lines @@
     galleryFrame.src = 'js/image_editor/gallery.html';
     this.dialogDom_.appendChild(galleryFrame);
     galleryFrame.focus();
   };
 
   /**
    * Update the breadcrumb display to reflect the current directory.
    */
   FileManager.prototype.updateBreadcrumbs_ = function() {
     var bc = this.dialogDom_.querySelector('.breadcrumbs');
-    bc.innerHTML = '';
+    removeChildren(bc);
 
     var fullPath = this.currentDirEntry_.fullPath.replace(/\/$/, '');
     var pathNames = fullPath.split('/');
     var path = '';
 
     for (var i = 0; i < pathNames.length; i++) {
       var pathName = pathNames[i];
       path += pathName + '/';
 
       var div = this.document_.createElement('div');
@@ skipping 1523 matching lines @@
           });
       }, onError);
 
       function onError(err) {
         console.log('Error while checking free space: ' + err);
         setTimeout(doCheck, 1000 * 60);
       }
     }
   }
 })();