Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5999)

Unified Diff: chrome/browser/extensions/extension_sync_data_unittest.cc

Issue 8727024: Save the oauth client id used in App Notification setup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed nits Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/browser/extensions/extension_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_sync_data_unittest.cc
diff --git a/chrome/browser/extensions/extension_sync_data_unittest.cc b/chrome/browser/extensions/extension_sync_data_unittest.cc
index 8526336c03c6c9f2d52eba5e269f08c4854e2e26..d62023eeaf3b9c3908fde6f1c65958f47c68e1bd 100644
--- a/chrome/browser/extensions/extension_sync_data_unittest.cc
+++ b/chrome/browser/extensions/extension_sync_data_unittest.cc
@@ -30,6 +30,7 @@ const char kValidUpdateUrl2[] =
"https://clients2.google.com/service/update2/crx";
const char kName[] = "MyExtension";
const char kName2[] = "MyExtension2";
+const char kOAuthClientId[] = "1234abcd";
class ExtensionSyncDataTest : public testing::Test {
};
@@ -101,7 +102,7 @@ TEST_F(ExtensionSyncDataTest, SyncDataToExtensionSyncDataForApp) {
extension_specifics->set_name(kName);
sync_pb::AppNotificationSettings* notif_settings =
app_specifics->mutable_notification_settings();
- notif_settings->set_initial_setup_done(true);
+ notif_settings->set_oauth_client_id(kOAuthClientId);
notif_settings->set_disabled(true);
SyncData sync_data =
SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
@@ -117,8 +118,8 @@ TEST_F(ExtensionSyncDataTest, SyncDataToExtensionSyncDataForApp) {
extension_sync_data.incognito_enabled());
EXPECT_EQ(extension_specifics->name(), extension_sync_data.name());
EXPECT_FALSE(extension_sync_data.uninstalled());
- EXPECT_EQ(notif_settings->initial_setup_done(),
- extension_sync_data.notifications_initial_setup_done());
+ EXPECT_EQ(notif_settings->oauth_client_id(),
+ extension_sync_data.notifications_client_id());
EXPECT_EQ(notif_settings->disabled(),
extension_sync_data.notifications_disabled());
}
@@ -137,7 +138,7 @@ TEST_F(ExtensionSyncDataTest, ExtensionSyncDataToSyncDataForApp) {
input_extension->set_name(kName);
sync_pb::AppNotificationSettings* notif_settings =
input_specifics->mutable_notification_settings();
- notif_settings->set_initial_setup_done(true);
+ notif_settings->set_oauth_client_id(kOAuthClientId);
notif_settings->set_disabled(true);
SyncData sync_data =
SyncData::CreateLocalData("sync_tag", "non_unique_title", entity);
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/browser/extensions/extension_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698