Save the oauth client id used in App Notification setup

chrome/browser/extensions/extension_sync_data.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_
 #pragma once
 
 #include <string>
 
@@ skipping 11 matching lines @@
 
 // A class that encapsulates the synced properties of an Extension.
 class ExtensionSyncData {
  public:
   ExtensionSyncData();
   explicit ExtensionSyncData(const SyncData& sync_data);
   explicit ExtensionSyncData(const SyncChange& sync_change);
   ExtensionSyncData(const Extension& extension,
                     bool enabled,
                     bool incognito_enabled,
-                    bool notifications_initial_setup_done,
+                    const std::string& notifications_client_id,
                     bool notifications_disabled);
   ~ExtensionSyncData();
 
   // Convert an ExtensionSyncData back out to a sync structure.
   void PopulateSyncSpecifics(sync_pb::ExtensionSpecifics* specifics) const;
   void PopulateAppSpecifics(sync_pb::AppSpecifics* specifics) const;
   SyncData GetSyncData() const;
   SyncChange GetSyncChange(SyncChange::SyncChangeType change_type) const;
 
   const std::string& id() const { return id_; }
 
   // Version-independent properties (i.e., used even when the
   // version of the currently-installed extension doesn't match
   // |version|).
   bool uninstalled() const { return uninstalled_; }
   bool enabled() const { return enabled_; }
   bool incognito_enabled() const { return incognito_enabled_; }
   Extension::SyncType type() const { return type_; }
 
   // Version-dependent properties (i.e., should be used only when the
   // version of the currenty-installed extension matches |version|).
   const Version& version() const { return version_; }
   const GURL& update_url() const { return update_url_; }
   // Used only for debugging.
   const std::string& name() const { return name_; }
 
-  bool notifications_initial_setup_done() const {

[Munjal (Google), 2011/11/29 21:55:34]

May be keep this method also in addition to the new method to check if initial
setup is done? Name it IsInitialSetupDone?

[asargent_no_longer_on_chrome, 2011/11/30 06:06:20]

I thought the idea was that the initial_setup_done field in the sync protobuffer
was deprecated and we were going to stop using it (that's what the comment in
app_specifics.proto that you added says :) ). 

-    return notifications_initial_setup_done_;
+  const std::string& notifications_client_id() const {
+    return notifications_client_id_;
   }
 
   bool notifications_disabled() const {
     return notifications_disabled_;
   }
 
  private:
   void PopulateFromExtensionSpecifics(
       const sync_pb::ExtensionSpecifics& specifics);
   void PopulateFromSyncData(const SyncData& sync_data);
 
   std::string id_;
   bool uninstalled_;
   bool enabled_;
   bool incognito_enabled_;
   Extension::SyncType type_;
   Version version_;
   GURL update_url_;
   std::string name_;
-  bool notifications_initial_setup_done_;
+  std::string notifications_client_id_;
   bool notifications_disabled_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_