Issue 8727021: WebUI TaskManager: Turn it off-by-default on Win/Mac/Linux

Issue 8727021: WebUI TaskManager: Turn it off-by-default on Win/Mac/Linux (Closed)

Created:
9 years ago by yoshiki

Modified:
9 years ago

Reviewers:
mazda, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebUI TaskManager: Turn it off-by-default on Win/Mac/Linux WebUI Dialogs does not ship on M17 on Desktop Chromes (Win/Mac/Linux) so that task manager have been disabled temporary. BUG=97429 TEST=manual on linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112133

Patch Set 1 #

Patch Set 2 : merge fix #

Total comments: 2

Patch Set 3 : review fix #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/common.gypi	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mazda

http://codereview.chromium.org/8727021/diff/2001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/8727021/diff/2001/build/common.gypi#newcode332 build/common.gypi:332: 'webui_task_manager%': 0, Is this necessary?

9 years ago (2011-11-29 06:12:25 UTC) #2

Emmanuel Saint-loubert-Bié

I agree with mazda the second part seems unnecessary.

9 years ago (2011-11-29 06:17:39 UTC) #3

yoshiki

9 years ago (2011-11-29 13:38:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8727021/2002

9 years ago (2011-11-29 22:50:17 UTC) #6

Change committed as 112133

Expand Messages | Collapse Messages