Implement RSAPrivateKey::Copy()

crypto/rsa_private_key_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/rsa_private_key.h"
 
 #include <list>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 116 matching lines @@
 
 RSAPrivateKey::RSAPrivateKey() : provider_(NULL), key_(NULL) {}
 
 RSAPrivateKey::~RSAPrivateKey() {}
 
 bool RSAPrivateKey::InitProvider() {
   return FALSE != CryptAcquireContext(provider_.receive(), NULL, NULL,
                                       PROV_RSA_FULL, CRYPT_VERIFYCONTEXT);
 }
 
+RSAPrivateKey* RSAPrivateKey::Copy() const {
+  scoped_ptr<RSAPrivateKey> copy(new RSAPrivateKey());
+  if (!copy->InitProvider())

[wtc, 2011/11/30 00:58:10]

Instead of calling copy->InitProvider(), I think it is better
to just call
  copy->provider_ = CryptContextAddRef(provider_, NULL, 0);

[Sergey Ulanov, 2011/11/30 22:30:03]

Done.

+    return NULL;
+  if (!CryptDuplicateKey(key_.get(), NULL, 0, copy->key_.receive()))
+    return NULL;
+  return copy.release();
+}
+
 bool RSAPrivateKey::ExportPrivateKey(std::vector<uint8>* output) {
   // Export the key
   DWORD blob_length = 0;
   if (!CryptExportKey(key_, 0, PRIVATEKEYBLOB, 0, NULL, &blob_length)) {
     NOTREACHED();
     return false;
   }
 
   scoped_array<uint8> blob(new uint8[blob_length]);
   if (!CryptExportKey(key_, 0, PRIVATEKEYBLOB, 0, blob.get(), &blob_length)) {
@@ skipping 73 matching lines @@
       &encoded_length)) {
     NOTREACHED();
     return false;
   }
 
   output->assign(encoded.get(), encoded.get() + encoded_length);
   return true;
 }
 
 }  // namespace crypto