Implement RSAPrivateKey::Copy()

crypto/rsa_private_key_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/rsa_private_key.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // Generate random private keys with two different sizes. Reimport, then
@@ skipping 27 matching lines @@
   std::vector<uint8> privkey4;
   ASSERT_TRUE(keypair3->ExportPrivateKey(&privkey3));
   ASSERT_TRUE(keypair4->ExportPrivateKey(&privkey4));
 
   ASSERT_EQ(privkey1.size(), privkey3.size());
   ASSERT_EQ(privkey2.size(), privkey4.size());
   ASSERT_TRUE(0 == memcmp(&privkey1.front(), &privkey3.front(),
                           privkey1.size()));
   ASSERT_TRUE(0 == memcmp(&privkey2.front(), &privkey4.front(),
                           privkey2.size()));
+
+  scoped_ptr<crypto::RSAPrivateKey> keypair_copy(keypair1->Copy());
+  ASSERT_TRUE(keypair_copy.get());
+
+  std::vector<uint8> privkey_copy;
+  ASSERT_TRUE(keypair_copy->ExportPrivateKey(&privkey_copy));
+  ASSERT_EQ(privkey1, privkey_copy);

[wtc, 2011/11/30 00:58:10]

It would be nice to create a separate test for the Copy()
method.

[Sergey Ulanov, 2011/11/30 22:30:03]

Done.

[wtc, 2011/11/30 23:44:37]

You didn't upload a new patch set.  Not sure if you forgot
to do that or you're still working on this CL.

 }
 
 
 // Verify that generated public keys look good. This test data was generated
 // with the openssl command line tool.
 TEST(RSAPrivateKeyUnitTest, PublicKeyTest) {
   const uint8 private_key_info[] = {
     0x30, 0x82, 0x02, 0x78, 0x02, 0x01, 0x00, 0x30, 
     0x0d, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7, 
     0x0d, 0x01, 0x01, 0x01, 0x05, 0x00, 0x04, 0x82, 
@@ skipping 319 matching lines @@
   ASSERT_TRUE(keypair1->ExportPrivateKey(&output1));
   ASSERT_TRUE(keypair2->ExportPrivateKey(&output2));
 
   ASSERT_EQ(input1.size(), output1.size());
   ASSERT_EQ(input2.size(), output2.size());
   ASSERT_TRUE(0 == memcmp(&output1.front(), &input1.front(),
                           input1.size()));
   ASSERT_TRUE(0 == memcmp(&output2.front(), &input2.front(),
                           input2.size()));
 }