Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 8727010: Send one WebKeyboardEvent to the RenderWidget at a time. Move keyboard (Closed)

Created:
9 years ago by darin (slow to review)
Modified:
9 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Send one WebKeyboardEvent to the RenderWidget at a time. Move keyboard shortcut handling to the RenderWidgetHost. R=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -97 lines) Patch
M content/browser/renderer_host/render_widget_host.h View 4 chunks +30 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 9 chunks +89 lines, -59 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
darin (slow to review)
9 years ago (2011-11-29 00:32:56 UTC) #1
darin (slow to review)
Background: I'm making this change to simplify event handling for the threaded compositor. The InputEventFilter ...
9 years ago (2011-11-29 00:37:15 UTC) #2
jam
lgtm (caveat being that I'm not that familiar with the input forwarding code)
9 years ago (2011-11-29 02:57:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/8727010/1
9 years ago (2011-11-29 18:19:11 UTC) #4
commit-bot: I haz the power
Try job failure for 8727010-1 (retry) (retry) on linux_rel for step "interactive_ui_tests" (clobber build). It's ...
9 years ago (2011-11-29 20:25:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/8727010/1
9 years ago (2011-11-30 05:19:03 UTC) #6
commit-bot: I haz the power
9 years ago (2011-11-30 08:17:58 UTC) #7
Change committed as 112160

Powered by Google App Engine
This is Rietveld 408576698