Partial swaps on OSX

content/browser/renderer_host/accelerated_surface_container_mac.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/accelerated_surface_container_mac.h"
 
 #include "base/logging.h"
 #include "content/browser/renderer_host/accelerated_surface_container_manager_mac.h"
 #include "ui/gfx/surface/io_surface_support_mac.h"
 #include "webkit/plugins/npapi/webplugin.h"
@@ skipping 100 matching lines @@
                                                surface_width_,
                                                surface_height_,
                                                GL_BGRA,
                                                GL_UNSIGNED_INT_8_8_8_8_REV,
                                                surface_.get(),
                                                plane);
     texture_needs_upload_ = false;
   }
   // If using TransportDIBs, the texture needs to be uploaded every frame.
   if (transport_dib_.get() != NULL) {
-    void* pixel_memory = transport_dib_->memory();
+    unsigned char* pixel_memory =
+        static_cast<unsigned char*>(transport_dib_->memory());
     if (pixel_memory) {
       glBindTexture(target, texture_);
       glPixelStorei(GL_UNPACK_ALIGNMENT, 1);  // Needed for NPOT textures.
-      glTexSubImage2D(target,
-                      0,  // mipmap level 0
-                      0,  // x-offset
-                      0,  // y-offset
-                      width_,
-                      height_,
-                      GL_BGRA,  // The GPU plugin gave us BGRA pixels
-                      GL_UNSIGNED_INT_8_8_8_8_REV,
-                      pixel_memory);
+      if (update_rect_.IsEmpty()) {
+        glTexSubImage2D(target,
+                        0,  // mipmap level 0
+                        0,  // x-offset
+                        0,  // y-offset
+                        width_,
+                        height_,
+                        GL_BGRA,  // The GPU plugin gave us BGRA pixels
+                        GL_UNSIGNED_INT_8_8_8_8_REV,
+                        pixel_memory);
+      } else {
+        glPixelStorei(GL_UNPACK_ROW_LENGTH, width_);
+        glTexSubImage2D(target,
+                        0,  // mipmap level 0
+                        update_rect_.x(),  // x-offset
+                        update_rect_.y(),  // y-offset
+                        update_rect_.width(),
+                        update_rect_.height(),
+                        GL_BGRA,  // The GPU plugin gave us BGRA pixels
+                        GL_UNSIGNED_INT_8_8_8_8_REV,
+                        &pixel_memory[(update_rect_.x() +
+                                       update_rect_.y() * width_) * 4]);
+        glPixelStorei(GL_UNPACK_ROW_LENGTH, 0);
+      }
     }
   }
+  update_rect_ = gfx::Rect();
 
   if (texture_) {
     int texture_width = io_surface_support ? surface_width_ : width_;
     int texture_height = io_surface_support ? surface_height_ : height_;
 
     // TODO(kbr): convert this to use only OpenGL ES 2.0 functionality.
 
     // TODO(kbr): may need to pay attention to cutout rects.
     int clipX = clip_rect_.x();
     int clipY = clip_rect_.y();
@@ skipping 49 matching lines @@
 
     glEnd();
     glDisable(target);
   }
 }
 
 bool AcceleratedSurfaceContainerMac::ShouldBeVisible() const {
   return visible_ && was_painted_to_ && !clip_rect_.IsEmpty();
 }
 
-void AcceleratedSurfaceContainerMac::set_was_painted_to(uint64 surface_id) {
+void AcceleratedSurfaceContainerMac::set_was_painted_to_common(
+    uint64 surface_id) {
   if (surface_id && (!surface_ || surface_id != surface_id_)) {
     // Keep the surface that was most recently painted to around.
     if (IOSurfaceSupport* io_surface_support = IOSurfaceSupport::Initialize()) {
       CFTypeRef surface = io_surface_support->IOSurfaceLookup(
           static_cast<uint32>(surface_id));
       // Can fail if IOSurface with that ID was already released by the
       // gpu process or the plugin process. We will get a |set_was_painted_to()|
       // message with a new surface soon in that case.
       if (surface) {
         surface_.reset(surface);
         surface_id_ = surface_id;
         surface_width_ = io_surface_support->IOSurfaceGetWidth(surface_);
         surface_height_ = io_surface_support->IOSurfaceGetHeight(surface_);
         EnqueueTextureForDeletion();
       }
     }
   }
   was_painted_to_ = true;
 }
 
+void AcceleratedSurfaceContainerMac::set_was_painted_to(uint64 surface_id) {

[sky, 2011/12/06 19:40:39]

nit: position should match header.

[jonathan.backer, 2011/12/06 20:24:41]

Done.

+  set_was_painted_to_common(surface_id);
+  update_rect_ = gfx::Rect();
+}
+
+void AcceleratedSurfaceContainerMac::set_was_painted_to(
+   uint64 surface_id,
+   const gfx::Rect& update_rect) {
+  set_was_painted_to_common(surface_id);
+  update_rect_ = update_rect_.Union(update_rect);
+}
+
 void AcceleratedSurfaceContainerMac::EnqueueTextureForDeletion() {
   if (texture_) {
     DCHECK(texture_pending_deletion_ == 0);
     texture_pending_deletion_ = texture_;
     texture_ = 0;
   }
 }