Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: content/browser/renderer_host/java/java_bound_object.cc

Issue 8726005: Fix an incorrect comment in the Java Bridge when calling array methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/java/java_bound_object.cc
diff --git a/content/browser/renderer_host/java/java_bound_object.cc b/content/browser/renderer_host/java/java_bound_object.cc
index ff113d43513ed3f92143973a43e6a5d3d27c6cd1..b87917ba48cefdfc38b36f4a14c2ba8247a08d15 100644
--- a/content/browser/renderer_host/java/java_bound_object.cc
+++ b/content/browser/renderer_host/java/java_bound_object.cc
@@ -153,7 +153,9 @@ NPVariant CallJNIMethod(jobject object, JavaType::Type return_type,
VOID_TO_NPVARIANT(result);
break;
case JavaType::TypeArray:
- // TODO(steveblock): Handle arrays
+ // LIVECONNECT_COMPLIANCE: Don't call methods that return arrays, to
+ // maintain existing behavior. We should call the method and convert the
bulach 2011/11/29 11:11:14 is the second sentence a TODO? also, I got comment
Steve Block 2011/11/29 11:18:00 It't not really a TODO. This file has many comment
bulach 2011/11/29 11:46:19 got it, thanks for the clarification!
+ // result to a JavaScript array.
VOID_TO_NPVARIANT(result);
break;
case JavaType::TypeString: {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698