Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 8725034: network_library: Add a few policy-configured test networks. (Closed)

Created:
9 years ago by Mattias Nissler (ping if slow)
Modified:
9 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

network_library: Add a few policy-configured test networks. This makes it easier to validate policy-specific UI behavior. BUG=chromium-os:23124 TEST=compiles and passes tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112602

Patch Set 1 #

Patch Set 2 : Fix unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -6 lines) Patch
M chrome/browser/chromeos/cros/network_library.cc View 1 5 chunks +67 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mattias Nissler (ping if slow)
Split out and with fixed-up tests.
9 years ago (2011-11-29 21:28:41 UTC) #1
stevenjb
lgtm
9 years ago (2011-11-29 23:02:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/8725034/2001
9 years ago (2011-12-01 18:31:52 UTC) #3
commit-bot: I haz the power
Try job failure for 8725034-2001 (retry) on mac_rel for steps "browser_tests, ui_tests" (clobber build). It's ...
9 years ago (2011-12-01 20:08:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/8725034/2001
9 years ago (2011-12-01 22:39:25 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-02 02:23:09 UTC) #6
Change committed as 112602

Powered by Google App Engine
This is Rietveld 408576698