Issue 8725032: Prepare push to trunk. Now working on version 3.7.12.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8725032: Prepare push to trunk. Now working on version 3.7.12. (Closed)

Created:
9 years ago by Michael Starzinger

Modified:
9 years ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.7.12. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=10088

Patch Set 2 : Addressed comments by Erik Corry. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/8725032/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/8725032/diff/1/ChangeLog#newcode3 ChangeLog:3: Fix bug when generating padding to ensure space ...

9 years ago (2011-11-29 14:15:22 UTC) #2

Michael Starzinger

9 years ago (2011-11-29 14:22:05 UTC) #3

Added new patch set. Landed.

http://codereview.chromium.org/8725032/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/8725032/diff/1/ChangeLog#newcode3
ChangeLog:3: Fix bug when generating padding to ensure space for lazy
deoptimization.
On 2011/11/29 14:15:22, Erik Corry wrote:
> Fix -> Fixed and below Implement->Implemented

Done.

http://codereview.chromium.org/8725032/diff/1/ChangeLog#newcode6
ChangeLog:6: Only sweep one page eagerly unless we are running out of space.
Limit
On 2011/11/29 14:15:22, Erik Corry wrote:
> Perhaps these should jsut be summed up as "Further reduced pause times due to
> GC".

Done.

Expand Messages | Collapse Messages

Issue 8725032: Prepare push to trunk. Now working on version 3.7.12. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Erik Corry. #

Messages