Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 8725019: Move another bunch of extension API tests to manifest_version 2. (Closed)

Created:
9 years ago by abarth-chromium
Modified:
9 years ago
Reviewers:
aa
CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, dcheng, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

Move another bunch of extension API tests to manifest_version 2. These extensions are loaded as unpacked extensions, so they need to be updated to version 2 before we can change every unpacked extension to use version 2. BUG=62897 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1859 lines, -1554 lines) Patch
M chrome/test/data/extensions/api_test/chrome_auth_private/enable_chrome_connector/cloud_print_success_tests.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/chrome_auth_private/enable_chrome_connector/cloud_print_success_tests.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/chrome_auth_private/installed_app/background.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/chrome_auth_private/installed_app/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/chrome_auth_private/installed_component_app/background.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/chrome_auth_private/installed_component_app/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/chromeos_info_private/background.html View 1 chunk +6 lines, -58 lines 0 comments Download
A chrome/test/data/extensions/api_test/chromeos_info_private/background.js View 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/chromeos_info_private/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clear/api/background.html View 1 chunk +6 lines, -40 lines 0 comments Download
A chrome/test/data/extensions/api_test/clear/api/background.js View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clear/api/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clear/one_at_a_time/background.html View 1 chunk +6 lines, -47 lines 0 comments Download
A chrome/test/data/extensions/api_test/clear/one_at_a_time/background.js View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clear/one_at_a_time/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/extension/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/extension/test.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/extension/test.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/extension_no_permission/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/hosted_app/main.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/hosted_app/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/clipboard/hosted_app_no_permission/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.html View 1 chunk +6 lines, -22 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/all_frames/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/all_frames/test.html View 1 chunk +6 lines, -40 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/all_frames/test.js View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/css_l10n/background.html View 1 chunk +6 lines, -74 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/css_l10n/background.js View 1 chunk +74 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/css_l10n/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/dont_match_host_permissions/background.html View 1 chunk +6 lines, -29 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/dont_match_host_permissions/background.js View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/dont_match_host_permissions/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/existing_renderers/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_api/fire_event.html View 1 chunk +6 lines, -3 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/extension_api/fire_event.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_api/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.html View 1 chunk +6 lines, -14 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_iframe/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_iframe/test.html View 1 chunk +6 lines, -23 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/extension_iframe/test.js View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_process/background.html View 1 chunk +4 lines, -29 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/extension_process/background.js View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_process/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/fragment/background.html View 1 chunk +6 lines, -77 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/fragment/background.js View 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/fragment/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.html View 1 chunk +6 lines, -27 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/isolated_world1/background.js View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.html View 1 chunk +6 lines, -18 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/isolated_world2/background.js View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/isolated_world2/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/view_source/background.html View 1 chunk +6 lines, -28 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_scripts/view_source/background.js View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/view_source/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_security_policy/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/getresourceidentifiers/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/getresourceidentifiers/test.html View 1 chunk +6 lines, -40 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_settings/getresourceidentifiers/test.js View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/standard/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_settings/standard/test.html View 1 chunk +6 lines, -92 lines 0 comments Download
A chrome/test/data/extensions/api_test/content_settings/standard/test.js View 1 chunk +95 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/background.html View 1 chunk +6 lines, -5 lines 0 comments Download
A chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/background.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/popup.html View 1 chunk +6 lines, -8 lines 0 comments Download
A chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/popup.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/popup2.html View 1 chunk +6 lines, -8 lines 0 comments Download
A chrome/test/data/extensions/api_test/context_menus/add_from_multiple_contexts/popup2.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/basics/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/basics/test.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/no_perms/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/context_menus/no_perms/test.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/api/background.html View 1 chunk +6 lines, -16 lines 0 comments Download
A chrome/test/data/extensions/api_test/cookies/api/background.js View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/api/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/api/tab.html View 1 chunk +6 lines, -383 lines 0 comments Download
A chrome/test/data/extensions/api_test/cookies/api/tab.js View 1 chunk +385 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/events/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/events/test.html View 1 chunk +6 lines, -146 lines 0 comments Download
A chrome/test/data/extensions/api_test/cookies/events/test.js View 1 chunk +148 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/no_permission/background.html View 1 chunk +6 lines, -17 lines 0 comments Download
A chrome/test/data/extensions/api_test/cookies/no_permission/background.js View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cookies/no_permission/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/all_urls/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/all_urls/test.html View 1 chunk +6 lines, -47 lines 0 comments Download
A chrome/test/data/extensions/api_test/cross_origin_xhr/all_urls/test.js View 1 chunk +48 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.html View 1 chunk +6 lines, -59 lines 0 comments Download
A chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js View 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/content_script/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/content_script/test.html View 1 chunk +6 lines, -65 lines 0 comments Download
A chrome/test/data/extensions/api_test/cross_origin_xhr/content_script/test.js View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/file_access/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/file_access/test.html View 1 chunk +6 lines, -25 lines 0 comments Download
A chrome/test/data/extensions/api_test/cross_origin_xhr/file_access/test.js View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.html View 1 chunk +6 lines, -23 lines 0 comments Download
A chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/debugger/background.html View 1 chunk +6 lines, -84 lines 0 comments Download
A chrome/test/data/extensions/api_test/debugger/background.js View 1 chunk +85 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/debugger/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/decode_jpeg/background.html View 1 chunk +6 lines, -6 lines 0 comments Download
A chrome/test/data/extensions/api_test/decode_jpeg/background.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/decode_jpeg/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
Here's another one of these. If it's ok with you, I'm going to land these ...
9 years ago (2011-11-29 02:05:36 UTC) #1
Aaron Boodman
Yes, TBR is fine. LGTM
9 years ago (2011-11-29 05:44:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/8725019/1
9 years ago (2011-11-29 16:35:32 UTC) #3
commit-bot: I haz the power
9 years ago (2011-11-29 16:36:01 UTC) #4
Can't apply patch for file
chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json.
While running patch -p0 --forward --force;
patching file
chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/data/extensions/api_test/content_scripts/isolated_world1/manifest.json.rej

Powered by Google App Engine
This is Rietveld 408576698