Issue 8725006: Default to disable profiling in Win XP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8725006: Default to disable profiling in Win XP (Closed)

Created:
9 years ago by jar (doing other things)

Modified:
9 years ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Default to disable profiling in Win XP XP has a leak in memory, and is not calling thread local store destructors on thread teardown. Until we get this fixed, we'll disable profiling to reduce the impact of the leak. Without this patch, worker thread continual creation and destruction will leak ThreadData context structures. r=rvargas BUG=103209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111815

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages