Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 8724014: Only enable improved SafeBrowsing download protection on Windows. (Closed)

Created:
9 years ago by noelutz
Modified:
9 years ago
Reviewers:
mattm, Brian Ryner
CC:
chromium-reviews, Paweł Hajdan Jr., Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Only enable improved SafeBrowsing download protection on Windows. The UI is currently only implemented on Windows. This CL will disable the enhanced protection for all non-Windows OSes by simply not sending any server request and always returning a SAFE verdict to API clients. BUG=102540 TEST=No visible change. Run all unit-tests for DownloadProtectionServiceTest. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112513

Patch Set 1 #

Patch Set 2 : Fix some unit-tests #

Total comments: 2

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 2 7 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
noelutz
9 years ago (2011-11-30 17:14:22 UTC) #1
mattm
lgtm
9 years ago (2011-11-30 21:41:03 UTC) #2
Brian Ryner
lgtm http://codereview.chromium.org/8724014/diff/2001/chrome/browser/safe_browsing/download_protection_service_unittest.cc File chrome/browser/safe_browsing/download_protection_service_unittest.cc (right): http://codereview.chromium.org/8724014/diff/2001/chrome/browser/safe_browsing/download_protection_service_unittest.cc#newcode382 chrome/browser/safe_browsing/download_protection_service_unittest.cc:382: // we'll be lookup up the download hash. ...
9 years ago (2011-11-30 21:45:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/8724014/7001
9 years ago (2011-11-30 22:54:53 UTC) #4
commit-bot: I haz the power
Try job failure for 8724014-7001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 23:26:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/8724014/7001
9 years ago (2011-12-01 18:50:29 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-01 20:15:43 UTC) #7
Change committed as 112513

Powered by Google App Engine
This is Rietveld 408576698