subprocess2.py - Issue 8722001: Improve testing by comparing behavior of subprocess to subprocess2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 8722001: Improve testing by comparing behavior of subprocess to subprocess2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: PYLINTTTTTTTTTT! Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 8964aad7d495b9bcc2e10e1ffc12f6bb6b61b5d7..e65186e769cd5998bc509491ba9fa70fc5053717 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -310,4 +310,6 @@ def check_output(args, **kwargs):

- As per doc, "The stdout argument is not allowed as it is used internally."

"""

kwargs.setdefault('stdin', VOID)

+ if 'stdout' in kwargs:

+ raise ValueError('stdout argument not allowed, it will be overridden.')

return check_call_out(args, stdout=PIPE, **kwargs)[0]

« no previous file with comments | « no previous file | tests/subprocess2_test.py » ('j') | no next file with comments »