Improve testing by comparing behavior of subprocess to subprocess2

Improve testing by comparing behavior of subprocess to subprocess2

This makes sure no regression relative to subprocess is introduced in
subprocess2.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112217

[Dirk Pranke, 2011-11-28 22:31:50]

lgtm.

http://codereview.chromium.org/8722001/diff/2001/tests/subprocess2_test.py
File tests/subprocess2_test.py (right):

http://codereview.chromium.org/8722001/diff/2001/tests/subprocess2_test.py#ne...
tests/subprocess2_test.py:193: First |function| argument is the convertion for
the origianl expected LF
typos: "conversion" and "original".

[commit-bot: I haz the power, 2011-11-30 02:10:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8722001/5002

[commit-bot: I haz the power, 2011-11-30 02:16:49]

Presubmit check for 8722001-5002 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
tests/subprocess2_test.py failed!
Command tests/subprocess2_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
.....a
bb
ccc
a
bb
ccc
.EEEEEa
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
.....
======================================================================
ERROR: test_check_output_no_stdout (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 223, in test_check_output_no_stdout
    subp.check_output(self.exe, stdout=subp.PIPE)
AttributeError: 'module' object has no attribute 'check_output'

======================================================================
ERROR: test_check_output_throw_no_stderr (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 248, in
test_check_output_throw_no_stderr
    self._run_test(fn)
  File "tests/subprocess2_test.py", line 201, in _run_test
    function(noop, self.exe, False, subp)
  File "tests/subprocess2_test.py", line 242, in fn
    subp.check_output(
AttributeError: 'module' object has no attribute 'check_output'

======================================================================
ERROR: test_check_output_throw_stderr (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 261, in test_check_output_throw_stderr
    self._run_test(fn)
  File "tests/subprocess2_test.py", line 201, in _run_test
    function(noop, self.exe, False, subp)
  File "tests/subprocess2_test.py", line 253, in fn
    subp.check_output(
AttributeError: 'module' object has no attribute 'check_output'

======================================================================
ERROR: test_check_output_throw_stderr_stdout (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 274, in
test_check_output_throw_stderr_stdout
    self._run_test(fn)
  File "tests/subprocess2_test.py", line 201, in _run_test
    function(noop, self.exe, False, subp)
  File "tests/subprocess2_test.py", line 266, in fn
    subp.check_output(
AttributeError: 'module' object has no attribute 'check_output'

======================================================================
ERROR: test_check_output_throw_stdout (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 237, in test_check_output_throw_stdout
    self._run_test(fn)
  File "tests/subprocess2_test.py", line 201, in _run_test
    function(noop, self.exe, False, subp)
  File "tests/subprocess2_test.py", line 231, in fn
    subp.check_output(
AttributeError: 'module' object has no attribute 'check_output'

----------------------------------------------------------------------
Ran 16 tests in 2.168s

FAILED (errors=5)


Presubmit checks took 386.6s to calculate.

[M-A Ruel, 2011-11-30 02:40:25]

On 2011/11/30 02:16:49, I haz the power (commit-bot) wrote:
> AttributeError: 'module' object has no attribute 'check_output'

Ah, subprocess.check_output was introduced in python 2.7 and the CQ uses 2.6. I
slightly modified subprocess2_test.py to check if the regression test can be
safely run.

Queueing again.

[commit-bot: I haz the power, 2011-11-30 02:40:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8722001/10001

[commit-bot: I haz the power, 2011-11-30 02:46:49]

Presubmit check for 8722001-10001 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module subprocess2_test
E1101:230,0:RegressionTest.test_check_output_no_stdout: Module 'subprocess' has
no 'check_output' member
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 371.3s to calculate.

[commit-bot: I haz the power, 2011-11-30 02:56:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8722001/10001

[commit-bot: I haz the power, 2011-11-30 03:02:34]

Presubmit check for 8722001-10001 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module subprocess2_test
E1101:230,0:RegressionTest.test_check_output_no_stdout: Module 'subprocess' has
no 'check_output' member
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 362.0s to calculate.

[M-A Ruel, 2011-11-30 03:03:45]

On 2011/11/30 03:02:34, I haz the power (commit-bot) wrote:
> ************* Module subprocess2_test
> E1101:230,0:RegressionTest.test_check_output_no_stdout: Module 'subprocess'
has
> no 'check_output' member

Wow, I ran it manually and it passed fine. I'll look tomorrow to figure out.
Sorry for the noise.

[commit-bot: I haz the power, 2011-11-30 13:37:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8722001/13002

[commit-bot: I haz the power, 2011-11-30 13:43:50]

Presubmit check for 8722001-13002 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module subprocess2_test
E1101:230,0:RegressionTest.test_check_output_no_stdout: Module 'subprocess' has
no 'check_output' member
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 387.5s to calculate.

[commit-bot: I haz the power, 2011-11-30 13:48:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8722001/9006

[commit-bot: I haz the power, 2011-11-30 13:55:02]

Presubmit check for 8722001-9006 failed and returned exit status 1.

Running presubmit commit checks ...
************* Module subprocess2_test
E1101:231,0:RegressionTest.test_check_output_no_stdout: Module 'subprocess' has
no 'check_output' member
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
Fix pylint errors first.

tests/subprocess2_test.py failed!
Command tests/subprocess2_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
.....a
bb
ccc
a
bb
ccc
.Fa
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
....a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
a
bb
ccc
.....
======================================================================
FAIL: test_check_output_no_stdout (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/subprocess2_test.py", line 227, in test_check_output_no_stdout
    self.assertEquals((2, 6), sys.version_info)
AssertionError: (2, 6) != (2, 6, 5, 'final', 0)

----------------------------------------------------------------------
Ran 16 tests in 4.381s

FAILED (failures=1)


Presubmit checks took 362.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2011-11-30 13:57:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8722001/14002

[commit-bot: I haz the power, 2011-11-30 14:03:16]

Change committed as 112217