Wrap forward declarations in their relevant namespace

Wrap forward declarations in their relevant namespace

Forward declarations can't simply use "class $namespace::$class;" syntax.  Instead one needs to use "namespace $namespace { class $class; }" syntax.

[vega.james_gmail.com, 2008-10-29 23:09:57]

It seems older compilers are lax about this, but it causes problems with gcc4.3.

[agl, 2008-11-03 19:42:55]

http://codereview.chromium.org/8722/diff/1/2
File chrome/browser/history/thumbnail_database.h (right):

http://codereview.chromium.org/8722/diff/1/2#newcode19
Line 19: class Time;
For a scope this small, we should indent a couple of spaces here.

http://codereview.chromium.org/8722/diff/1/3
File chrome/browser/views/old_frames/vista_frame.h (right):

http://codereview.chromium.org/8722/diff/1/3#newcode35
Line 35: class FocusManager;
likewise.

http://codereview.chromium.org/8722/diff/1/4
File chrome/browser/webdata/web_database.h (right):

http://codereview.chromium.org/8722/diff/1/4#newcode18
Line 18: class Time;
likewise.

[Dean McNamee, 2008-11-03 20:21:48]

Can we use the class foo::Blah syntax if the namespace was already defined
somewhere?  Maybe we should have a header that declares the common namespaces,
and then just include that.  Would be nicer than wrapping a ton of things in
namespace { }

On 2008/11/03 19:42:55, agl wrote:
> http://codereview.chromium.org/8722/diff/1/2
> File chrome/browser/history/thumbnail_database.h (right):
> 
> http://codereview.chromium.org/8722/diff/1/2#newcode19
> Line 19: class Time;
> For a scope this small, we should indent a couple of spaces here.
> 
> http://codereview.chromium.org/8722/diff/1/3
> File chrome/browser/views/old_frames/vista_frame.h (right):
> 
> http://codereview.chromium.org/8722/diff/1/3#newcode35
> Line 35: class FocusManager;
> likewise.
> 
> http://codereview.chromium.org/8722/diff/1/4
> File chrome/browser/webdata/web_database.h (right):
> 
> http://codereview.chromium.org/8722/diff/1/4#newcode18
> Line 18: class Time;
> likewise.

[vega.james_gmail.com, 2008-11-03 20:41:34]

On 2008/11/03 20:21:48, Dean McNamee wrote:
> Can we use the class foo::Blah syntax if the namespace was already defined
> somewhere?  Maybe we should have a header that declares the common namespaces,
> and then just include that.

It isn't a matter of lacking declarations.  That just isn't proper syntax for
doing forward declarations of classes in a namespace.  Using "using namespace;"
or wrapping in "namspace { }" is the proper approach.

[vega.james_gmail.com, 2008-11-05 15:38:39]

r4723

[wtc, 2008-11-05 21:40:32]

http://codereview.chromium.org/8722/diff/9/10
File chrome/browser/history/thumbnail_database.h (right):

http://codereview.chromium.org/8722/diff/9/10#newcode18
Line 18: namespace base {
The "namespace" line was indented by accident.

http://codereview.chromium.org/8722/diff/9/11
File chrome/browser/views/old_frames/vista_frame.h (right):

http://codereview.chromium.org/8722/diff/9/11#newcode35
Line 35: class FocusManager;
The contents of namespaces don't need to be indented.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespace_Form...

http://codereview.chromium.org/8722/diff/9/12
File chrome/browser/webdata/web_database.h (right):

http://codereview.chromium.org/8722/diff/9/12#newcode18
Line 18: class Time;
Same as above.

[vega.james_gmail.com, 2008-11-05 21:55:33]

Thanks for the comments, but this has already been committed (hence why the
review is closed).  Not sure if someone that is able wants to fix the mixed up
indentation in chrome/browser/history/thumbnail_database.h.

http://codereview.chromium.org/8722/diff/9/10
File chrome/browser/history/thumbnail_database.h (right):

http://codereview.chromium.org/8722/diff/9/10#newcode18
Line 18: namespace base {
On 2008/11/05 21:40:32, wtc wrote:
> The "namespace" line was indented by accident.

Hmm, don't know how I missed that I indented the wrong line.

http://codereview.chromium.org/8722/diff/9/11
File chrome/browser/views/old_frames/vista_frame.h (right):

http://codereview.chromium.org/8722/diff/9/11#newcode35
Line 35: class FocusManager;
On 2008/11/05 21:40:32, wtc wrote:
> The contents of namespaces don't need to be indented.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespace_Form...

agl specifically requested it since these are such small namespace blocks.  See
previous comments in the review.