Issue 872004: Heuristically avoid reporting crashes during DLL loading....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 872004: Heuristically avoid reporting crashes during DLL loading.... (Closed)

Created:
10 years, 9 months ago by Sigurður Ásgeirsson

Modified:
9 years, 7 months ago

Reviewers:
robertshield

CC:
chromium-reviews, amit, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Heuristically avoid reporting crashes during DLL loading. Cleanup white space as requested by Robert in CL 882001. BUG=31980 TEST=Unittests in this change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41367

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -18 lines)			Patch
M	chrome_frame/crash_reporting/crash_dll.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/crash_reporting/nt_loader.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome_frame/crash_reporting/nt_loader_unittest.cc	View		4 chunks	+33 lines, -7 lines	2 comments	Download
M	chrome_frame/crash_reporting/vectored_handler-impl.h	View	1	4 chunks	+32 lines, -1 line	0 comments	Download
M	chrome_frame/crash_reporting/vectored_handler_unittest.cc	View		4 chunks	+46 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertshield

LGTM http://codereview.chromium.org/872004/diff/8001/9002 File chrome_frame/crash_reporting/nt_loader_unittest.cc (right): http://codereview.chromium.org/872004/diff/8001/9002#newcode146 chrome_frame/crash_reporting/nt_loader_unittest.cc:146: if (0 == (flags & LDRP_IMAGE_DLL)) { nit: ...

10 years, 9 months ago (2010-03-11 22:10:56 UTC) #2

Sigurður Ásgeirsson

10 years, 9 months ago (2010-03-11 22:13:52 UTC) #3

thanks!

http://codereview.chromium.org/872004/diff/8001/9002
File chrome_frame/crash_reporting/nt_loader_unittest.cc (right):

http://codereview.chromium.org/872004/diff/8001/9002#newcode146
chrome_frame/crash_reporting/nt_loader_unittest.cc:146: if (0 == (flags &
LDRP_IMAGE_DLL)) {
On 2010/03/11 22:10:56, robertshield wrote:
> nit: if you feel like it, and are bored, and are very bored then you could add
a
> test to see what happens when you LoadLibrary() an exe module into the running
> process.

Adding a TODO.

Expand Messages | Collapse Messages