chrome/browser/resources/file_manager/main.html - Issue 8720006: Moving file selection checkbox to the field name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/main.html

Issue 8720006: Moving file selection checkbox to the field name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review fix. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/file_manager/main.html

diff --git a/chrome/browser/resources/file_manager/main.html b/chrome/browser/resources/file_manager/main.html

index 1e343f5629e60b8c89ef38fd508e8f62b44261ad..cb2231756e58f8967eb836ded1a838ee67c65363 100644

--- a/chrome/browser/resources/file_manager/main.html

+++ b/chrome/browser/resources/file_manager/main.html

@@ -4,10 +4,11 @@

-- Use of this source code is governed by a BSD-style license that can be

-- found in the LICENSE file.

-->

-<html>

+<html i18n-values="dir:textdirection;">

<head>

+ <base href="">

// Instruction for enabling loading file manager files remotely (speeds up

// development cycle):

@@ -23,17 +24,13 @@

// 4. Open the File Manager. Execute the following JS code in its context

// using DevTools:

- // localStorage['base'] = 'http://yourmachine:1080/file_manager/'

+ // localStorage.base = 'http://yourmachine:1080/file_manager/'

// This will make the File Manager use fresh JS and CSS files from the

// development machine. HTML files and JS files for WebWorkers would still

// need a rebuild to update.

- if (localStorage['base']) {

- var base = document.createElement('base');

- base.setAttribute('href', localStorage['base']);

- document.head.appendChild(base);

- }

+ document.querySelector('base').setAttribute('href', localStorage.base);

</script>

</if>

<!-- metrics.js initiates load performance tracking