Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/resources/file_manager/main.html

Issue 8720006: Moving file selection checkbox to the field name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/main.html
diff --git a/chrome/browser/resources/file_manager/main.html b/chrome/browser/resources/file_manager/main.html
index 5c0db916b2baeb0a256271e37752a678019b43e6..0d0838895c66e4a399af6eceef55e8110748e671 100644
--- a/chrome/browser/resources/file_manager/main.html
+++ b/chrome/browser/resources/file_manager/main.html
@@ -8,6 +8,7 @@
<head>
<if expr="0">
<!-- <if ... /if> is removed while flattening HTML. -->
+ <base href="">
<script>
// Instruction for enabling loading file manager files remotely (speeds up
// development cycle):
@@ -23,17 +24,14 @@
//
// 4. Open the File Manager. Execute the following JS code in its context
// using DevTools:
- // localStorage['base'] = 'http://youmachine:1080/file_manager/'
+ // localStorage.base = 'http://yourmachine:1080/file_manager/'
//
// This will make the File Manager use fresh JS and CSS files from the
// development machine. HTML files and JS files for WebWorkers would still
// need a rebuild to update.
- if (localStorage['base']) {
- var base = document.createElement('base');
- base.setAttribute('href', localStorage['base']);
- document.head.appendChild(base);
- }
+ document.getElementsByTagName('base')[0].setAttribute('href',
Vladislav Kaznacheev 2011/11/29 19:11:59 document.querySelector('base') is cleaner
SeRya 2011/11/30 13:04:04 Fixed. Thanks.
+ localStorage.base);
</script>
</if>
<!-- metrics.js initiates load performance tracking

Powered by Google App Engine
This is Rietveld 408576698