Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 8719003: Add pylint presubmit check. (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add pylint presubmit check. All checks that were triggered were disabled in pylintrc. I put two lists, one of warnings that are worthless and one list with the warnings that should be enabled in a subsequent change. Since fixing these can be messy, this is left as an exercise to the reader. BUG= TEST= Committed: http://code.google.com/p/gyp/source/detail?r=1103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +10 lines, -0 lines 0 comments Download
A pylintrc View 1 chunk +307 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
In practice, I recommend fixing one warning per CL, it's easier to manage.
9 years ago (2011-11-28 16:13:52 UTC) #1
Mark Mentovai
9 years ago (2011-11-28 16:20:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698