media/audio/android/audio_track_output_stub_android.cc - Issue 8718014: Upstream: Media implementation for Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/audio/android/audio_track_output_stub_android.cc

Issue 8718014: Upstream: Media implementation for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "media/audio/android/audio_track_output_android.h"

	6

	7 // This file was added because there is no Java environment in

	8 // upstream yet, audio_track_output_android.cc should be used in

	9 // downstream.
	John Grabowski 2011/11/29 19:43:31 Add TODO(michaelbai) to be clear we intend to fini Add TODO(michaelbai) to be clear we intend to finish this. scherkus (not reviewing) 2011/11/29 20:00:28 is there a TODO or bug to reference here? I want is there a TODO or bug to reference here? I want to understand what benefit we have for including the .h but not even a fake implementation. Is the goal to catch compilation errors in the .h file? michaelbai 2011/11/30 17:20:34 Our current goal is make the media tests linked, e Show quoted text On 2011/11/29 20:00:28, scherkus wrote: > is there a TODO or bug to reference here? > > I want to understand what benefit we have for including the .h but not even a > fake implementation. Is the goal to catch compilation errors in the .h file? Our current goal is make the media tests linked, even it might not be run correctly.
	10

	11 // static

	12 AudioOutputStream* AudioTrackOutputStream::MakeStream(

	13 AudioManagerAndroid* manager, const AudioParameters& params) {

	14 return NULL;

	15 }

OLD	NEW