Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 8718012: Revert 111695 - Have content/ create and destroy its own threads. (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
Reviewers:
Jói
CC:
chromium-reviews, Alexander Potapenko, sadrul, nkostylev+watch_chromium.org, Timur Iskhodzhanov, amit, stuartmorgan+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, ncarter (slow), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, dhollowa, tim (not reviewing), derat+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, dpranke-watch+content_chromium.org, pam+watch_chromium.org, akalin, tfarina, robertshield, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 111695 - Have content/ create and destroy its own threads. Reason: Problems on official builders. Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716, 104578, 105435 Review URL: http://codereview.chromium.org/8477004 TBR=joi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -955 lines) Patch
M chrome/browser/browser_process_impl.h View 6 chunks +28 lines, -23 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 10 chunks +154 lines, -85 lines 0 comments Download
M chrome/browser/browser_shutdown.h View 1 chunk +7 lines, -12 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 4 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 21 chunks +62 lines, -89 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 7 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/io_thread.h View 3 chunks +10 lines, -37 lines 0 comments Download
M chrome/browser/io_thread.cc View 8 chunks +16 lines, -37 lines 0 comments Download
M chrome/browser/sync/tools/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 3 chunks +18 lines, -9 lines 0 comments Download
MM chrome/browser/ui/gtk/gtk_util.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 6 chunks +10 lines, -34 lines 0 comments Download
M content/browser/browser_main_loop.h View 4 chunks +0 lines, -17 lines 0 comments Download
M content/browser/browser_main_loop.cc View 4 chunks +0 lines, -199 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/browser_thread_impl.h View 2 chunks +5 lines, -23 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 7 chunks +70 lines, -90 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 3 chunks +0 lines, -33 lines 0 comments Download
D content/public/browser/browser_shutdown.h View 1 chunk +0 lines, -32 lines 0 comments Download
M content/public/browser/browser_thread.h View 4 chunks +37 lines, -44 lines 0 comments Download
D content/public/browser/browser_thread_delegate.h View 1 chunk +0 lines, -32 lines 0 comments Download
M content/shell/shell_browser_context.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/shell/shell_browser_main.h View 1 chunk +11 lines, -8 lines 0 comments Download
M content/shell/shell_browser_main.cc View 2 chunks +33 lines, -16 lines 0 comments Download
M content/test/test_browser_thread.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/test/test_browser_thread.cc View 2 chunks +2 lines, -30 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download
M views/accessible_pane_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Jói
9 years ago (2011-11-28 14:00:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698