Issue 8718008: Fix canary build failure on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8718008: Fix canary build failure on Mac (Closed)

Created:
9 years ago by hayato

Modified:
9 years ago

Reviewers:
Mark Mentovai, Hironori Bono

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix canary build failure on Mac. BUG=105530 TEST=None

Patch Set 1 #

Patch Set 2 : added the description. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	third_party/apple_webkit/README.chromium	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
	M	third_party/apple_webkit/WebKitSystemInterface.h	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hayato

On 2011/11/28 09:25:34, hayato wrote: After I commit this patch on Chromium side, I'll try ...

9 years ago (2011-11-28 09:27:55 UTC) #2

hayato

9 years ago (2011-11-28 11:09:33 UTC) #3

Instead of this patch, I tried to fix this issue on WebKit as:
https://trac.webkit.org/changeset/101241

Let me close this review.

On 2011/11/28 09:27:55, hayato wrote:
> On 2011/11/28 09:25:34, hayato wrote:
> 
> After I commit this patch on Chromium side, I'll try to roll WebKit.

Expand Messages | Collapse Messages