Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 8718002: Cocoa: Fix avatar menu shortcut (Closed)

Created:
9 years ago by sail
Modified:
9 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Cocoa: Fix avatar menu shortcut If focus was in the Omnibox then pressing Command-M would incorrectly trigger the avatar menu. The problem was due to the fact that when MatchesEventForKeyboardShortcut() matches against a key character it ignores the shift flag. Fix was to use a key code for the shortcut so that the shift flag was correctly checked. BUG=104457 TEST=Verified that Command-Shift-M correctly showed the avatar menu while focused on a web page and while focused on the location bar. Verified that Command-M correctly minimized the window while focused on a web page and focused on the location bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sail
9 years ago (2011-11-28 00:46:52 UTC) #1
Robert Sesek
lgtm
9 years ago (2011-11-28 15:05:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8718002/1
9 years ago (2011-11-28 15:18:28 UTC) #3
commit-bot: I haz the power
9 years ago (2011-11-28 16:10:57 UTC) #4
Try job failure for 8718002-1 (retry) on linux_rel for step
"interactive_ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698