Add profile avatar to profile delete dialog.

Add profile avatar to profile delete dialog. 

BUG=102135
TEST=Have multiple profiles created. Go to "Personal Stuff" options. Delete one of the profiles from the list of profiles. The avatar for the profile being deleted should appear in the dialog.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112374

[Evan Stade, 2011-11-29 00:17:37]

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.css (right):

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.css:82: {
this curly is on the wrong line

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.html (right):

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.html:28: <img
id="delete-profile-avatar" class="profile-icon">
instead of adding an <img>, set the image as the background for
delete-profile-message (without repeating, of course, and you have to add more
padding or margin to move the text over)

[jwd, 2011-11-29 17:13:44]

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.html (right):

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.html:28: <img
id="delete-profile-avatar" class="profile-icon">
I would expect RTL languages to put the avatar on the right (similar to how the
list of users does). Can this be achieved with this strategy? I notice start
isn't a valid value for background-position.

[Evan Stade, 2011-11-30 00:28:34]

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.html (right):

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.html:28: <img
id="delete-profile-avatar" class="profile-icon">
On 2011/11/29 17:13:44, Jesse Doherty wrote:
> I would expect RTL languages to put the avatar on the right (similar to how
the
> list of users does). Can this be achieved with this strategy? I notice start
> isn't a valid value for background-position.

yes, use a selector with html[dir=rtl]

[jwd, 2011-11-30 16:48:04]

Changes made.

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.css (right):

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.css:82: {
Done

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/manage_profile_overlay.html (right):

http://codereview.chromium.org/8715009/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/manage_profile_overlay.html:28: <img
id="delete-profile-avatar" class="profile-icon">
Done. 
Though it does seem to me that the image is part of the content, not the style,
similar to the avatar in the list of profiles. I don't have strong feelings
about it though.

[Evan Stade, 2011-11-30 23:03:53]

lgtm

[commit-bot: I haz the power, 2011-11-30 23:16:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/8715009/7002

[commit-bot: I haz the power, 2011-11-30 23:45:48]

Try job failure for 8715009-7002 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-01 00:03:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/8715009/7002

[commit-bot: I haz the power, 2011-12-01 02:11:19]

Change committed as 112374