Improve git-cl, add unit test!

Fix case where TBR=foo would remove the -r flag in git-cl

Add unit test!

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112220

[Dirk Pranke, 2011-11-28 22:27:56]

http://codereview.chromium.org/8715007/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/8715007/diff/1/git_cl.py#newcode646
git_cl.py:646: initial_text += '\nR=' + self.reviewers
If TBR is in the description and we specify -r foo on the command line, doesn't
this result in both TBR= and R= lines? I'm not sure what the best thing to do
here is.

http://codereview.chromium.org/8715007/diff/1/git_cl.py#newcode668
git_cl.py:668: matched_reviewers = re.search(r'\n\s*(TBR|R)=(.+)',
self.description)
see above ... what happens if we have more than one (TBR|R)= line?

[M-A Ruel, 2011-11-29 15:13:44]

ptal

http://codereview.chromium.org/8715007/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/8715007/diff/1/git_cl.py#newcode646
git_cl.py:646: initial_text += '\nR=' + self.reviewers
On 2011/11/28 22:27:56, Dirk Pranke wrote:
> If TBR is in the description and we specify -r foo on the command line,
doesn't
> this result in both TBR= and R= lines? I'm not sure what the best thing to do
> here is.

Oops. Just considerer TBR= in description too.

http://codereview.chromium.org/8715007/diff/1/git_cl.py#newcode668
git_cl.py:668: matched_reviewers = re.search(r'\n\s*(TBR|R)=(.+)',
self.description)
On 2011/11/28 22:27:56, Dirk Pranke wrote:
> see above ... what happens if we have more than one (TBR|R)= line?

Thanks, I redid the logic.

[Dirk Pranke, 2011-11-29 23:51:56]

lgtm.

http://codereview.chromium.org/8715007/diff/4001/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/8715007/diff/4001/git_cl.py#newcode671
git_cl.py:671: regexp = re.compile(r'^\s*(TBR|R)=(.+)$', re.MULTILINE)
Nit: I'm not sure you need or want re.MULTILINE here?

[M-A Ruel, 2011-11-30 14:14:18]

http://codereview.chromium.org/8715007/diff/4001/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/8715007/diff/4001/git_cl.py#newcode671
git_cl.py:671: regexp = re.compile(r'^\s*(TBR|R)=(.+)$', re.MULTILINE)
On 2011/11/29 23:51:57, Dirk Pranke wrote:
> Nit: I'm not sure you need or want re.MULTILINE here?

Yes it's necessary.

[commit-bot: I haz the power, 2011-11-30 14:14:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8715007/4001

[commit-bot: I haz the power, 2011-11-30 14:20:40]

Change committed as 112220