Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 8715004: Fix assertion while marking Harmony weak maps. (Closed)

Created:
9 years ago by Michael Starzinger
Modified:
9 years ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix assertion while marking Harmony weak maps. R=erik.corry@gmail.com BUG=v8:1845 TEST=mjsunit/harmony/proxies-example-membrane Committed: http://code.google.com/p/v8/source/detail?r=10081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M src/mark-compact.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
The strong root set is marked after PrepareForCodeFlushing() is called, which in turn can trigger ...
9 years ago (2011-11-28 14:48:06 UTC) #1
Erik Corry
9 years ago (2011-11-28 21:21:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698