base::Bind: Convert IPC::SendTask.

base::Bind: Convert IPC::SendTask.

BUG=none
TEST=none

R=groby@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111837

[James Hawkins, 2011-11-28 04:58:20]

Albert, I don't think my change here is 100% correct.  The original code ensures
that one of the bound parameters is deleted *only* if the callback is not run. 
base::Owned takes ownership of the parameter and deletes it no matter if the
callback is run or not.  Is there a way to implement the original behavior w/
base::Bind?

[awong, 2011-11-28 18:38:11]

Unfortunately there is no way to do this yet.

There's a bug out for this:

 http://code.google.com/p/chromium/issues/detail?id=96118

and a CL:

  http://codereview.chromium.org/8224026/
  
But there is an ongoing debate about whether or not this is worth the
complexity.

For now, the answer is to use a helper class like they originally had.

[James Hawkins, 2011-11-28 19:27:28]

In the meantime, I rewrote the wrapper as you suggested. Check it out.

[groby-ooo-7-16, 2011-11-28 19:44:47]

lgtm

[awong, 2011-11-28 19:48:23]

LGTM w/ nit

http://codereview.chromium.org/8714003/diff/5001/ipc/ipc_channel_proxy.h
File ipc/ipc_channel_proxy.h (right):

http://codereview.chromium.org/8714003/diff/5001/ipc/ipc_channel_proxy.h#newc...
ipc/ipc_channel_proxy.h:20: class SendCallbackCleaner;
nit: I'd call this SendCallbackCarrier, SendCallbackOwner, or maybe even
SendCallbackHelper.  Cleaner sounds like it's a "cleaner version" of
something...

Don't really feel strongly though.

[James Hawkins, 2011-11-28 20:52:42]

http://codereview.chromium.org/8714003/diff/5001/ipc/ipc_channel_proxy.h
File ipc/ipc_channel_proxy.h (right):

http://codereview.chromium.org/8714003/diff/5001/ipc/ipc_channel_proxy.h#newc...
ipc/ipc_channel_proxy.h:20: class SendCallbackCleaner;
On 2011/11/28 19:48:23, awong wrote:
> nit: I'd call this SendCallbackCarrier, SendCallbackOwner, or maybe even
> SendCallbackHelper.  Cleaner sounds like it's a "cleaner version" of
> something...
> 
> Don't really feel strongly though.

Done.

[awong, 2011-11-28 20:53:23]

LGTM++

Thanks!