WebUI TaskManager: Optimize initialization taskmanager and loading scripts.

chrome/browser/resources/task_manager/main.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @constructor */
 function TaskManager() { }
 
 cr.addSingletonGetter(TaskManager);
 
 /*
@@ skipping 127 matching lines @@
    * @public
    */
   initialize: function (dialogDom, opt) {
     if (!dialogDom) {
       console.log('ERROR: dialogDom is not defined.');
       return;
     }
 
     this.opt_ = opt;
 
-    this.initialized_ = true;
     this.enableTaskManager();
 
     this.dialogDom_ = dialogDom;
     this.document_ = dialogDom.ownerDocument;
 
-    $('close-window').addEventListener('click', this.close.bind(this));
-    $('kill-process').addEventListener('click', this.killProcess.bind(this));
-    $('about-memory-link').addEventListener('click',
-                                            this.openAboutMemory.bind(this));
+    var ary = this.dialogDom_.querySelectorAll('[visibleif]');
+    for (var i = 0; i < ary.length; i++) {
+      var expr = ary[i].getAttribute('visibleif');
+      if (!eval(expr))
+        ary[i].hidden = true;
+    }
 
     this.is_column_shown_ = [];
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       this.is_column_shown_[i] = DEFAULT_COLUMNS[i][3];
     }
 
     this.localized_column_ = [];
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column_label_id = DEFAULT_COLUMNS[i][1];
       var localized_label = localStrings.getString(column_label_id);
@@ skipping 28 matching lines @@
               var aValues = a[value_id];
               var bValues = b[value_id];
               var aValue = aValues && aValues[0] || 0;
               var bvalue = bValues && bValues[0] || 0;
               return dm.defaultValuesCompareFunction(aValue, bvalue);
           };
       }();
       dm.setCompareFunction(column_id, compare_func);
     }
 
-    var ary = this.dialogDom_.querySelectorAll('[visibleif]');
-    for (var i = 0; i < ary.length; i++) {
-      var expr = ary[i].getAttribute('visibleif');
-      if (!eval(expr))
-        ary[i].hidden = true;
-    }
+    this.initTable_();
+    this.initialized_ = true;
 
-    this.initTable_();
+    loadDelayedIncludes(this);
+  },
+
+  /**
+   * Additional initialization of taskmanager. This function is called when
+   * the loading of delayed scripts finished.
+   * @public
+   */
+  delayedInitialize: function () {
+    $('close-window').addEventListener('click', this.close.bind(this));
+    $('kill-process').addEventListener('click', this.killProcess.bind(this));
+    $('about-memory-link').addEventListener('click',
+                                            this.openAboutMemory.bind(this));
     this.initColumnMenu_();
     this.initTableMenu_();
-    this.table_.redraw();
+
+    this.isFinishedInitDelayed_ = true;
   },
 
   initColumnModel_: function () {
     var table_columns = new Array();
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       if (!this.is_column_shown_[i])
         continue;
 
       var column = DEFAULT_COLUMNS[i];
       table_columns.push(new cr.ui.table.TableColumn(column[0],
@@ skipping 135 matching lines @@
         if (columnId == 'title') {
           var image = this.document_.createElement('img');
           image.className = 'detail-title-image';
           image.src = entry['icon'][i];
           label.appendChild(image);
           var text = this.document_.createElement('div');
           text.className = 'detail-title-text';
           text.textContent = entry['title'][i];
           label.appendChild(text);
 
-          cr.ui.contextMenuHandler.addContextMenuProperty(label);
-          label.contextMenu = this.tableContextMenu_;
+          if (this.isFinishedInitDelayed_) {

[mazda, 2011/12/05 03:42:11]

Is it OK to reach here when this.isFinishedInitDelaed_ is false?

[yoshiki, 2011/12/05 08:38:15]

It's ok. This block adds context menu handler to label. If it is skipped, only
context menu does not work.

On 2011/12/05 03:42:11, mazda wrote:

[mazda, 2011/12/06 09:58:18]

I think it's undesirable. 
How about storing the labels and initializing them in delayedInitialize if
|this.isFinishedInitDelayed_| is false?

[yoshiki, 2011/12/07 16:01:09]

Done.

+            cr.ui.contextMenuHandler.addContextMenuProperty(label);
+            label.contextMenu = this.tableContextMenu_;
+          }
 
           label.addEventListener('dblclick', (function(uniqueId) {
               this.activatePage(uniqueId);
           }).bind(this, entry['uniqueId'][i]));
 
           label.data = entry;
           label.index_in_group = i;
         } else {
           label.textContent = entry[columnId][i];
         }
@@ skipping 178 matching lines @@
   taskmanager.onTaskChange(start, length, tasks);
 }
 
 function taskRemoved(start, length) {
   // Sometimes this can get called too early.
   if (!taskmanager)
     return;
   taskmanager.onTaskRemove(start, length);
 }