Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: runtime/include/dart_api.h

Issue 8713012: Introduce Dart_SetVMFlags API function. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Force atomicity. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/dart.h » ('j') | runtime/vm/dart.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index da0c31ffbe9923e9c0bc79e9c9a1be324178ad57..1e2f69cdba14821da1ab00b8a84e7cae0397eaae 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -247,17 +247,22 @@ typedef void* (*Dart_IsolateInitCallback)(void* embedder_data);
// TODO(turnidge): Should we separate the two return values?
/**
- * Initializes the VM with the given commmand line flags.
+ * Initializes the VM.
*
- * \param argc The length of the arguments array.
- * \param argv An array of arguments.
* \param callback A function to be called during isolate creation.
* See Dart_IsolateInitCallback.
*
* \return True if initialization is successful.
*/
-DART_EXPORT bool Dart_Initialize(int argc, const char** argv,
- Dart_IsolateInitCallback callback);
+DART_EXPORT bool Dart_Initialize(Dart_IsolateInitCallback callback);
+
+/**
+ * Sets command line flags. Should be called before Dart_Initialize.
+ *
+ * \param argc The length of the arguments array.
+ * \param argv An array of arguments.
+ */
+DART_EXPORT void Dart_SetVMFlags(int argc, const char** argv);
siva 2011/11/30 19:09:38 Please make this also return bool, so that we have
podivilov 2011/12/01 11:10:22 Done.
/**
* Returns true if the named VM flag is set.
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/dart.h » ('j') | runtime/vm/dart.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698