Enable WebUI ScreenLocker for aura by abstracting lock window.

chrome/browser/chromeos/login/lock_window_aura.h

Index: chrome/browser/chromeos/login/lock_window_aura.h
diff --git a/chrome/browser/chromeos/login/lock_window_aura.h b/chrome/browser/chromeos/login/lock_window_aura.h
new file mode 100644
index 0000000000000000000000000000000000000000..23542704fd8f47bc7274a13f588780605b8728bb
--- /dev/null
+++ b/chrome/browser/chromeos/login/lock_window_aura.h
@@ -0,0 +1,35 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WINDOW_AURA_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WINDOW_AURA_H_
+#pragma once
+
+#include <cstddef>

[oshima, 2011/11/29 20:18:06]

do we need this here?

[flackr, 2011/11/30 20:16:54]

This include was for NULL. Not needed here.

+

[oshima, 2011/11/29 20:18:06]

base/compiler_specific.h (for iwyu)

[flackr, 2011/11/30 20:16:54]

Done.

+#include "chrome/browser/chromeos/login/lock_window.h"
+#include "ui/views/widget/widget.h"
+
+namespace chromeos {
+
+class LockWindowAura : public views::Widget,
+                       public LockWindow {

[oshima, 2011/11/29 20:18:06]

When we need different impl for different platform, we typically put them in
NativeWidget (see TabContentsView and NativeTabContentsViewXXX as an example).
It may not work well in this case though. Can you look into it?

[flackr, 2011/11/30 20:16:54]

I'm not exactly sure what you mean. Do you mean to subclass NativeWidget as
LockWindowGtk does? TabContentsView seems to have TabContentsView(Win|Mac|Gtk),
and  the NativeTabContentsView interface is very similar to LockWindow interface
except that all implementations subclass NativeWidgetXXX.

[oshima, 2011/11/30 23:41:07]

I was thinking something like LockWindow being just a Widget and provide
difference in NativeWidget via params.native_widget (like you did in gtk)

I thought this may actually make the code simpler/smaller because
you don't need SetContents/GetWidget , although I may be wrong.

[flackr, 2011/12/01 21:40:40]

To do this I will likely have to introduce "if defined" into the lock_window
code. Only the GTK version requires observing grab and render status, as well as
grabbing a particular widget which means selectively calling functions on the
NativeWidget. I can avoid having to define SetContents by using the actual
widget as I have done in patch 7.

[oshima, 2011/12/01 22:45:35]

It it doesn't help, then I'm fine with current approach.

+ public:
+  LockWindowAura();

[oshima, 2011/11/29 20:18:06]

move this to private and add friend to LockWindow.

[flackr, 2011/11/30 20:16:54]

Done.

+
+  // LockWindow implementation:
+  virtual void SetContentsView(views::View* content) OVERRIDE;
+  virtual void Show(DOMView* dom_view) OVERRIDE;
+  virtual views::Widget* GetWidget() OVERRIDE;
+
+ private:
+  virtual ~LockWindowAura() {}

[oshima, 2011/11/29 20:18:06]

move to .cc

[flackr, 2011/11/30 20:16:54]

Done.

+
+  // Initialize the Aura lock window.
+  void Init();
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_WINDOW_AURA_H_