Add GAIA picture to Settings profile overlay

Add GAIA picture to Settings profile overlay

This CL allows users to choose their GAIA profile picture as their browser profile avatar.

Screenshots: http://imgur.com/TLXR8,tdHIt#0

BUG=91241
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112166

[binji, 2011-11-28 19:09:20]

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:148: if
(new_profile_name == cache.GetGAIANameOfProfileAtIndex(profile_index)) {
Could you keep the comment? Maybe add something about how changing any of these
values could change the profile index -- it is not obvious.

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:148: if
(new_profile_name == cache.GetGAIANameOfProfileAtIndex(profile_index)) {
Is it safe to compare against the GAIA name here? What if the user typed it?

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:227:
profile_value.SetString("iconURL", web_ui_util::GetImageDataUrl(icon));
might be a little nicer to send the GAIA name to javascript here. That way you
don't have to bounce back to C++ to set the profile name.

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/personal_options_handler.cc:421:
!cache.GetGAIAPictureOfProfileAtIndex(i).IsNull();
Add a helper function for this? It is used in a few places already.

[sail, 2011-11-28 19:33:36]

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:148: if
(new_profile_name == cache.GetGAIANameOfProfileAtIndex(profile_index)) {
On 2011/11/28 19:09:20, binji wrote:
> Could you keep the comment? Maybe add something about how changing any of
these
> values could change the profile index -- it is not obvious.

Good point. Fixed.
(Note, I'm cleaning this up and getting rid of the profile index in a different
CL).

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:148: if
(new_profile_name == cache.GetGAIANameOfProfileAtIndex(profile_index)) {
On 2011/11/28 19:09:20, binji wrote:
> Is it safe to compare against the GAIA name here? What if the user typed it?

I agree that the behavior is a little weird if the user typed their GAIA name
explicitly. It's not that big a deal because all it means is that the profile
name now gets auto updated. I added a comment explaining this.

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:227:
profile_value.SetString("iconURL", web_ui_util::GetImageDataUrl(icon));
On 2011/11/28 19:09:20, binji wrote:
> might be a little nicer to send the GAIA name to javascript here. That way you
> don't have to bounce back to C++ to set the profile name.

It's a littler tricker that way because the javascript code doesn't know which
of the profile icons is the GAIA picture.

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/personal_options_handler.cc:421:
!cache.GetGAIAPictureOfProfileAtIndex(i).IsNull();
On 2011/11/28 19:09:20, binji wrote:
> Add a helper function for this? It is used in a few places already.

This is going away in a future refactoring
(http://codereview.chromium.org/8539043/). Mind if I leave it for now?

[binji, 2011-11-28 19:47:41]

lgtm

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/manage_profile_handler.cc (right):

http://codereview.chromium.org/8711002/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/manage_profile_handler.cc:227:
profile_value.SetString("iconURL", web_ui_util::GetImageDataUrl(icon));
On 2011/11/28 19:33:36, sail wrote:
> On 2011/11/28 19:09:20, binji wrote:
> > might be a little nicer to send the GAIA name to javascript here. That way
you
> > don't have to bounce back to C++ to set the profile name.
> 
> It's a littler tricker that way because the javascript code doesn't know which
> of the profile icons is the GAIA picture.

OK, I see what you mean.