Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/codegen-ia32.cc

Issue 8708: Fix out-of-date comment. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 Comment cmnt_token(masm_, Token::String(op)); 793 Comment cmnt_token(masm_, Token::String(op));
794 794
795 if (op == Token::COMMA) { 795 if (op == Token::COMMA) {
796 // Simply discard left value. 796 // Simply discard left value.
797 frame_->Pop(eax); 797 frame_->Pop(eax);
798 frame_->Pop(); 798 frame_->Pop();
799 frame_->Push(eax); 799 frame_->Push(eax);
800 return; 800 return;
801 } 801 }
802 802
803 // For now, we keep the old behavior and only inline the smi code 803 // Set the flags based on the operation, type and loop nesting level.
804 // for the bitwise operations.
805 GenericBinaryFlags flags; 804 GenericBinaryFlags flags;
806 switch (op) { 805 switch (op) {
807 case Token::BIT_OR: 806 case Token::BIT_OR:
808 case Token::BIT_AND: 807 case Token::BIT_AND:
809 case Token::BIT_XOR: 808 case Token::BIT_XOR:
810 case Token::SHL: 809 case Token::SHL:
811 case Token::SHR: 810 case Token::SHR:
812 case Token::SAR: 811 case Token::SAR:
813 // Bit operations always assume they likely operate on Smis. Still only 812 // Bit operations always assume they likely operate on Smis. Still only
814 // generate the inline Smi check code if this operation is part of a loop. 813 // generate the inline Smi check code if this operation is part of a loop.
(...skipping 4306 matching lines...) Expand 10 before | Expand all | Expand 10 after
5121 5120
5122 // Slow-case: Go through the JavaScript implementation. 5121 // Slow-case: Go through the JavaScript implementation.
5123 __ bind(&slow); 5122 __ bind(&slow);
5124 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION); 5123 __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION);
5125 } 5124 }
5126 5125
5127 5126
5128 #undef __ 5127 #undef __
5129 5128
5130 } } // namespace v8::internal 5129 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698