Extend the use of IOBuffers to the code underneath...

net/base/tcp_client_socket_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/address_list.h"
 #include "net/base/host_resolver.h"
 #include "net/base/listen_socket.h"
 #include "net/base/net_errors.h"
 #include "net/base/tcp_client_socket.h"
 #include "net/base/test_completion_callback.h"
@@ skipping 85 matching lines @@
   TestCompletionCallback callback;
   int rv = sock_->Connect(&callback);
   if (rv != net::OK) {
     ASSERT_EQ(rv, net::ERR_IO_PENDING);
 
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, net::OK);
   }
 
   const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
-  rv = sock_->Write(request_text, arraysize(request_text) - 1, &callback);
+  scoped_refptr<net::IOBuffer> request_buffer =
+      new net::IOBuffer(arraysize(request_text) - 1);
+  memcpy(request_buffer->data(), request_text, arraysize(request_text) - 1);
+
+  rv = sock_->Write(request_buffer, arraysize(request_text) - 1, &callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING) {
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, static_cast<int>(arraysize(request_text) - 1));
   }
 
-  char buf[4096];
+  scoped_refptr<net::IOBuffer> buf = new net::IOBuffer(4096);
   for (;;) {
-    rv = sock_->Read(buf, sizeof(buf), &callback);
+    rv = sock_->Read(buf, 4096, &callback);
     EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
     if (rv == net::ERR_IO_PENDING)
       rv = callback.WaitForResult();
 
     EXPECT_GE(rv, 0);
     if (rv <= 0)
       break;
   }
 }
 
 TEST_F(TCPClientSocketTest, Read_SmallChunks) {
   TestCompletionCallback callback;
   int rv = sock_->Connect(&callback);
   if (rv != net::OK) {
     ASSERT_EQ(rv, net::ERR_IO_PENDING);
 
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, net::OK);
   }
 
   const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
-  rv = sock_->Write(request_text, arraysize(request_text) - 1, &callback);
+  scoped_refptr<net::IOBuffer> request_buffer =
+      new net::IOBuffer(arraysize(request_text) - 1);
+  memcpy(request_buffer->data(), request_text, arraysize(request_text) - 1);
+
+  rv = sock_->Write(request_buffer, arraysize(request_text) - 1, &callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING) {
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, static_cast<int>(arraysize(request_text) - 1));
   }
 
-  char buf[1];
+  scoped_refptr<net::IOBuffer> buf = new net::IOBuffer(1);
   for (;;) {
-    rv = sock_->Read(buf, sizeof(buf), &callback);
+    rv = sock_->Read(buf, 1, &callback);
     EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
     if (rv == net::ERR_IO_PENDING)
       rv = callback.WaitForResult();
 
     EXPECT_GE(rv, 0);
     if (rv <= 0)
       break;
   }
 }
 
 TEST_F(TCPClientSocketTest, Read_Interrupted) {
   TestCompletionCallback callback;
   int rv = sock_->Connect(&callback);
   if (rv != net::OK) {
     ASSERT_EQ(rv, net::ERR_IO_PENDING);
 
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, net::OK);
   }
 
   const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
-  rv = sock_->Write(request_text, arraysize(request_text) - 1, &callback);
+  scoped_refptr<net::IOBuffer> request_buffer =
+      new net::IOBuffer(arraysize(request_text) - 1);
+  memcpy(request_buffer->data(), request_text, arraysize(request_text) - 1);
+
+  rv = sock_->Write(request_buffer, arraysize(request_text) - 1, &callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING) {
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, static_cast<int>(arraysize(request_text) - 1));
   }
 
   // Do a partial read and then exit.  This test should not crash!
-  char buf[512];
-  rv = sock_->Read(buf, sizeof(buf), &callback);
+  scoped_refptr<net::IOBuffer> buf = new net::IOBuffer(512);
+  rv = sock_->Read(buf, 512, &callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING)
     rv = callback.WaitForResult();
 
   EXPECT_NE(rv, 0);
 }
 
 TEST_F(TCPClientSocketTest, FullDuplex_ReadFirst) {
   TestCompletionCallback callback;
   int rv = sock_->Connect(&callback);
   if (rv != net::OK) {
     ASSERT_EQ(rv, net::ERR_IO_PENDING);
 
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, net::OK);
   }
 
-  char buf[4096];
-  rv = sock_->Read(buf, sizeof(buf), &callback);
+  const int kBufLen = 4096;
+  scoped_refptr<net::IOBuffer> buf = new net::IOBuffer(kBufLen);
+  rv = sock_->Read(buf, kBufLen, &callback);
   EXPECT_EQ(net::ERR_IO_PENDING, rv);
 
   const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
+  scoped_refptr<net::IOBuffer> request_buffer =
+      new net::IOBuffer(arraysize(request_text) - 1);
+  memcpy(request_buffer->data(), request_text, arraysize(request_text) - 1);
   TestCompletionCallback write_callback;
-  rv = sock_->Write(request_text, arraysize(request_text) - 1, &write_callback);
+
+  rv = sock_->Write(request_buffer, arraysize(request_text) - 1,
+                    &write_callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING) {
     rv = write_callback.WaitForResult();
     EXPECT_EQ(rv, static_cast<int>(arraysize(request_text) - 1));
   }
 
   rv = callback.WaitForResult();
   EXPECT_GE(rv, 0);
   while (rv > 0) {
-    rv = sock_->Read(buf, sizeof(buf), &callback);
+    rv = sock_->Read(buf, kBufLen, &callback);
     EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
     if (rv == net::ERR_IO_PENDING)
       rv = callback.WaitForResult();
 
     EXPECT_GE(rv, 0);
     if (rv <= 0)
       break;
   }
 }
 
 TEST_F(TCPClientSocketTest, FullDuplex_WriteFirst) {
   TestCompletionCallback callback;
   int rv = sock_->Connect(&callback);
   if (rv != net::OK) {
     ASSERT_EQ(rv, net::ERR_IO_PENDING);
 
     rv = callback.WaitForResult();
     EXPECT_EQ(rv, net::OK);
   }
 
   const char request_text[] = "GET / HTTP/1.0\r\n\r\n";
+  scoped_refptr<net::IOBuffer> request_buffer =
+      new net::IOBuffer(arraysize(request_text) - 1);
+  memcpy(request_buffer->data(), request_text, arraysize(request_text) - 1);
   TestCompletionCallback write_callback;
-  rv = sock_->Write(request_text, arraysize(request_text) - 1, &write_callback);
+
+  rv = sock_->Write(request_buffer, arraysize(request_text) - 1,
+                    &write_callback);
   EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
-  char buf[4096];
-  int read_rv = sock_->Read(buf, sizeof(buf), &callback);
+  const int kBufLen = 4096;
+  scoped_refptr<net::IOBuffer> buf = new net::IOBuffer(kBufLen);
+  int read_rv = sock_->Read(buf, kBufLen, &callback);
   EXPECT_TRUE(read_rv >= 0 || read_rv == net::ERR_IO_PENDING);
 
   if (rv == net::ERR_IO_PENDING) {
     rv = write_callback.WaitForResult();
     EXPECT_EQ(static_cast<int>(arraysize(request_text) - 1), rv);
   }
 
   rv = callback.WaitForResult();
   EXPECT_GE(rv, 0);
   while (rv > 0) {
-    rv = sock_->Read(buf, sizeof(buf), &callback);
+    rv = sock_->Read(buf, kBufLen, &callback);
     EXPECT_TRUE(rv >= 0 || rv == net::ERR_IO_PENDING);
 
     if (rv == net::ERR_IO_PENDING)
       rv = callback.WaitForResult();
 
     EXPECT_GE(rv, 0);
     if (rv <= 0)
       break;
   }
 }