Extend the use of IOBuffers to the code underneath...

net/base/ssl_client_socket_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/ssl_client_socket_win.h"
 
 #include <schnlsp.h>
 
 #include "base/lock.h"
 #include "base/singleton.h"
@@ skipping 194 matching lines @@
 
 SSLClientSocketWin::SSLClientSocketWin(ClientSocket* transport_socket,
                                        const std::string& hostname,
                                        const SSLConfig& ssl_config)
 #pragma warning(suppress: 4355)
     : io_callback_(this, &SSLClientSocketWin::OnIOComplete),
       transport_(transport_socket),
       hostname_(hostname),
       ssl_config_(ssl_config),
       user_callback_(NULL),
-      user_buf_(NULL),
       user_buf_len_(0),
       next_state_(STATE_NONE),
       creds_(NULL),
       isc_status_(SEC_E_OK),
       payload_send_buffer_len_(0),
       bytes_sent_(0),
       decrypted_ptr_(NULL),
       bytes_decrypted_(0),
       received_ptr_(NULL),
       bytes_received_(0),
@@ skipping 130 matching lines @@
   // Unlike IsConnected, this method doesn't return a false positive.
   //
   // Strictly speaking, we should check if we have received the close_notify
   // alert message from the server, and return false in that case.  Although
   // the close_notify alert message means EOF in the SSL layer, it is just
   // bytes to the transport layer below, so transport_->IsConnectedAndIdle()
   // returns the desired false when we receive close_notify.
   return completed_handshake_ && transport_->IsConnectedAndIdle();
 }
 
-int SSLClientSocketWin::Read(char* buf, int buf_len,
+int SSLClientSocketWin::Read(IOBuffer* buf, int buf_len,
                              CompletionCallback* callback) {
   DCHECK(completed_handshake_);
   DCHECK(next_state_ == STATE_NONE);
   DCHECK(!user_callback_);
 
   // If we have surplus decrypted plaintext, satisfy the Read with it without
   // reading more ciphertext from the transport socket.
   if (bytes_decrypted_ != 0) {
     int len = std::min(buf_len, bytes_decrypted_);
-    memcpy(buf, decrypted_ptr_, len);
+    memcpy(buf->data(), decrypted_ptr_, len);
     decrypted_ptr_ += len;
     bytes_decrypted_ -= len;
     if (bytes_decrypted_ == 0) {
       decrypted_ptr_ = NULL;
       if (bytes_received_ != 0) {
         memmove(recv_buffer_.get(), received_ptr_, bytes_received_);
         received_ptr_ = recv_buffer_.get();
       }
     }
     return len;
   }
 
+  DCHECK(!user_buf_);
   user_buf_ = buf;
   user_buf_len_ = buf_len;
 
   SetNextStateForRead();
   int rv = DoLoop(OK);
-  if (rv == ERR_IO_PENDING)
+  if (rv == ERR_IO_PENDING) {
     user_callback_ = callback;
+  } else {
+    user_buf_ = NULL;
+  }
   return rv;
 }
 
-int SSLClientSocketWin::Write(const char* buf, int buf_len,
+int SSLClientSocketWin::Write(IOBuffer* buf, int buf_len,
                               CompletionCallback* callback) {
   DCHECK(completed_handshake_);
   DCHECK(next_state_ == STATE_NONE);
   DCHECK(!user_callback_);
 
-  user_buf_ = const_cast<char*>(buf);
+  DCHECK(!user_buf_);
+  user_buf_ = buf;
   user_buf_len_ = buf_len;
 
   next_state_ = STATE_PAYLOAD_ENCRYPT;
   int rv = DoLoop(OK);
-  if (rv == ERR_IO_PENDING)
+  if (rv == ERR_IO_PENDING) {
     user_callback_ = callback;
+  } else {
+    user_buf_ = NULL;
+  }
   return rv;
 }
 
 void SSLClientSocketWin::DoCallback(int rv) {
   DCHECK(rv != ERR_IO_PENDING);
   DCHECK(user_callback_);
 
   // since Run may result in Read being called, clear user_callback_ up front.
   CompletionCallback* c = user_callback_;
   user_callback_ = NULL;
+  user_buf_ = NULL;
   c->Run(rv);
 }
 
 void SSLClientSocketWin::OnIOComplete(int result) {
   int rv = DoLoop(result);
   if (rv != ERR_IO_PENDING)
     DoCallback(rv);
 }
 
 int SSLClientSocketWin::DoLoop(int last_io_result) {
@@ skipping 44 matching lines @@
   } while (rv != ERR_IO_PENDING && next_state_ != STATE_NONE);
   return rv;
 }
 
 int SSLClientSocketWin::DoHandshakeRead() {
   next_state_ = STATE_HANDSHAKE_READ_COMPLETE;
 
   if (!recv_buffer_.get())
     recv_buffer_.reset(new char[kRecvBufferSize]);
 
-  char* buf = recv_buffer_.get() + bytes_received_;
   int buf_len = kRecvBufferSize - bytes_received_;
 
   if (buf_len <= 0) {
     NOTREACHED() << "Receive buffer is too small!";
     return ERR_UNEXPECTED;
   }
 
-  return transport_->Read(buf, buf_len, &io_callback_);
+  DCHECK(!transport_buf_);
+  transport_buf_ = new IOBuffer(buf_len);
+
+  return transport_->Read(transport_buf_, buf_len, &io_callback_);
 }
 
 int SSLClientSocketWin::DoHandshakeReadComplete(int result) {
-  if (result < 0)
+  DCHECK(transport_buf_);
+  if (result < 0) {
+    transport_buf_ = NULL;
     return result;
+  }
+  DCHECK_LE(result, kRecvBufferSize - bytes_received_);
+  char* buf = recv_buffer_.get() + bytes_received_;
+  memcpy(buf, transport_buf_->data(), result);
+  transport_buf_ = NULL;
+
   if (result == 0 && !ignore_ok_result_)
     return ERR_SSL_PROTOCOL_ERROR;  // Incomplete response :(
 
   ignore_ok_result_ = false;
 
   bytes_received_ += result;
 
   // Process the contents of recv_buffer_.
   TimeStamp expiry;
   DWORD out_flags;
@@ skipping 107 matching lines @@
   next_state_ = STATE_HANDSHAKE_READ;
   return OK;
 }
 
 int SSLClientSocketWin::DoHandshakeWrite() {
   next_state_ = STATE_HANDSHAKE_WRITE_COMPLETE;
 
   // We should have something to send.
   DCHECK(send_buffer_.pvBuffer);
   DCHECK(send_buffer_.cbBuffer > 0);
+  DCHECK(!transport_buf_);
 
   const char* buf = static_cast<char*>(send_buffer_.pvBuffer) + bytes_sent_;
   int buf_len = send_buffer_.cbBuffer - bytes_sent_;
+  transport_buf_ = new IOBuffer(buf_len);
+  memcpy(transport_buf_->data(), buf, buf_len);
 
-  return transport_->Write(buf, buf_len, &io_callback_);
+  return transport_->Write(transport_buf_, buf_len, &io_callback_);
 }
 
 int SSLClientSocketWin::DoHandshakeWriteComplete(int result) {
+  DCHECK(transport_buf_);
+  transport_buf_ = NULL;
   if (result < 0)
     return result;
 
   DCHECK(result != 0);
 
   bytes_sent_ += result;
   DCHECK(bytes_sent_ <= static_cast<int>(send_buffer_.cbBuffer));
 
   if (bytes_sent_ >= static_cast<int>(send_buffer_.cbBuffer)) {
     bool overflow = (bytes_sent_ > static_cast<int>(send_buffer_.cbBuffer));
@@ skipping 51 matching lines @@
     DCHECK(next_state_ == STATE_NONE);
   }
   return result;
 }
 
 int SSLClientSocketWin::DoPayloadRead() {
   next_state_ = STATE_PAYLOAD_READ_COMPLETE;
 
   DCHECK(recv_buffer_.get());
 
-  char* buf = recv_buffer_.get() + bytes_received_;
   int buf_len = kRecvBufferSize - bytes_received_;
 
   if (buf_len <= 0) {
     NOTREACHED() << "Receive buffer is too small!";
     return ERR_FAILED;
   }
 
-  return transport_->Read(buf, buf_len, &io_callback_);
+  DCHECK(!transport_buf_);
+  transport_buf_ = new IOBuffer(buf_len);
+
+  return transport_->Read(transport_buf_, buf_len, &io_callback_);
 }
 
 int SSLClientSocketWin::DoPayloadReadComplete(int result) {
-  if (result < 0)
+  if (result < 0) {
+    transport_buf_ = NULL;
     return result;
+  }
+  if (transport_buf_) {
+    // This method is called after a state transition following DoPayloadRead(),
+    // or if SetNextStateForRead() was called. We have a transport_buf_ only
+    // in the first case, and we have to transfer the data from transport_buf_
+    // to recv_buffer_.
+    DCHECK_LE(result, kRecvBufferSize - bytes_received_);
+    char* buf = recv_buffer_.get() + bytes_received_;
+    memcpy(buf, transport_buf_->data(), result);
+    transport_buf_ = NULL;
+  }
+
   if (result == 0 && !ignore_ok_result_) {
     // TODO(wtc): Unless we have received the close_notify alert, we need to
     // return an error code indicating that the SSL connection ended
     // uncleanly, a potential truncation attack.
     if (bytes_received_ != 0)
       return ERR_FAILED;
     return OK;
   }
 
   ignore_ok_result_ = false;
@@ skipping 48 matching lines @@
     }
     if (!received_ptr_ && buffers[i].BufferType == SECBUFFER_EXTRA) {
       received_ptr_ = static_cast<char*>(buffers[i].pvBuffer);
       bytes_received_ = buffers[i].cbBuffer;
     }
   }
 
   int len = 0;
   if (bytes_decrypted_ != 0) {
     len = std::min(user_buf_len_, bytes_decrypted_);
-    memcpy(user_buf_, decrypted_ptr_, len);
+    memcpy(user_buf_->data(), decrypted_ptr_, len);
     decrypted_ptr_ += len;
     bytes_decrypted_ -= len;
   }
   if (bytes_decrypted_ == 0) {
     decrypted_ptr_ = NULL;
     if (bytes_received_ != 0) {
       memmove(recv_buffer_.get(), received_ptr_, bytes_received_);
       received_ptr_ = recv_buffer_.get();
     }
   }
@@ skipping 39 matching lines @@
   DCHECK(user_buf_len_ > 0);
 
   ULONG message_len = std::min(
       stream_sizes_.cbMaximumMessage, static_cast<ULONG>(user_buf_len_));
   ULONG alloc_len =
       message_len + stream_sizes_.cbHeader + stream_sizes_.cbTrailer;
   user_buf_len_ = message_len;
 
   payload_send_buffer_.reset(new char[alloc_len]);
   memcpy(&payload_send_buffer_[stream_sizes_.cbHeader],
-         user_buf_, message_len);
+         user_buf_->data(), message_len);
 
   SecBuffer buffers[4];
   buffers[0].pvBuffer = payload_send_buffer_.get();
   buffers[0].cbBuffer = stream_sizes_.cbHeader;
   buffers[0].BufferType = SECBUFFER_STREAM_HEADER;
 
   buffers[1].pvBuffer = &payload_send_buffer_[stream_sizes_.cbHeader];
   buffers[1].cbBuffer = message_len;
   buffers[1].BufferType = SECBUFFER_DATA;
 
@@ skipping 22 matching lines @@
   next_state_ = STATE_PAYLOAD_WRITE;
   return OK;
 }
 
 int SSLClientSocketWin::DoPayloadWrite() {
   next_state_ = STATE_PAYLOAD_WRITE_COMPLETE;
 
   // We should have something to send.
   DCHECK(payload_send_buffer_.get());
   DCHECK(payload_send_buffer_len_ > 0);
+  DCHECK(!transport_buf_);
 
   const char* buf = payload_send_buffer_.get() + bytes_sent_;
   int buf_len = payload_send_buffer_len_ - bytes_sent_;
+  transport_buf_ = new IOBuffer(buf_len);
+  memcpy(transport_buf_->data(), buf, buf_len);
 
-  return transport_->Write(buf, buf_len, &io_callback_);
+  return transport_->Write(transport_buf_, buf_len, &io_callback_);
 }
 
 int SSLClientSocketWin::DoPayloadWriteComplete(int result) {
+  DCHECK(transport_buf_);
+  transport_buf_ = NULL;
   if (result < 0)
     return result;
 
   DCHECK(result != 0);
 
   bytes_sent_ += result;
   DCHECK(bytes_sent_ <= payload_send_buffer_len_);
 
   if (bytes_sent_ >= payload_send_buffer_len_) {
     bool overflow = (bytes_sent_ > payload_send_buffer_len_);
@@ skipping 56 matching lines @@
   }
 }
 
 void SSLClientSocketWin::FreeSendBuffer() {
   SECURITY_STATUS status = FreeContextBuffer(send_buffer_.pvBuffer);
   DCHECK(status == SEC_E_OK);
   memset(&send_buffer_, 0, sizeof(send_buffer_));
 }
 
 }  // namespace net