Issue 8707001: Resolves crash related to conflict with latest WebRTC (1008) and the WebRTCAudioDeviceTest unit t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8707001: Resolves crash related to conflict with latest WebRTC (1008) and the WebRTCAudioDeviceTest unit t... (Closed)

Created:
9 years ago by henrika (OOO until Aug 14)

Modified:
9 years ago

Reviewers:
wjia(left Chromium), jam

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org, tommi (sloooow) - chröme, wjia(left Chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Resolves crash related to conflict with latest WebRTC (1008) and the WebRTCAudioDeviceTest unit test. This patch ensure that the ADM in Chrome reports the correct channel setting (stero/mono) to the using webrtc::VoiceEngine. BUG=none TEST=content_unittests --gtest_filter=WebRTCAudioDeviceTest* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111676

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	content/renderer/media/webrtc_audio_device_impl.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

henrika (OOO until Aug 14)

John, would really appreciate a quick OK here. This patch is trivial and only affects ...

9 years ago (2011-11-25 16:35:00 UTC) #1

jam

9 years ago (2011-11-25 18:51:15 UTC) #3

On 2011/11/25 16:41:45, wjia wrote:
> lgtm

my review isn't needed since there wjia already commented (he's in
content/renderer/media/OWNERS).

Expand Messages | Collapse Messages