Issue 87039: Fixes for comments on the review 87003....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87039: Fixes for comments on the review 87003.... (Closed)

Created:
11 years, 8 months ago by hamaji

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fixes for comments on the review 87003. - Use readdir_r() instead of readdir(). - Add comment why we use Time::TimeT(). - Increase the sleep time in unittest from 1000ms to 1500ms. - Use PlatformThread::Sleep() instead of sleep().

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	base/file_util_posix.cc	View	1 2 3	2 chunks	+17 lines, -1 line	0 comments	Download
	M	base/file_util_unittest.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hamaji

Thanks for the comments on my previous change. Could you check this fixes? Thanks,

11 years, 8 months ago (2009-04-21 19:22:19 UTC) #1

hamaji

On 2009/04/21 23:22:39, Erik Kay wrote: > LGTM - I'll submit this tomorrow. Thanks!

11 years, 8 months ago (2009-04-21 23:27:21 UTC) #3

hamaji

11 years, 8 months ago (2009-04-22 05:59:50 UTC) #4

On 2009/04/21 23:27:21, hamaji wrote:
> On 2009/04/21 23:22:39, Erik Kay wrote:
> > LGTM - I'll submit this tomorrow.
> 
> Thanks!

As Hironori kindly suggested, I added comments why we use Time::TimeT().

Expand Messages | Collapse Messages