DevTools: Support eventless host message dispatching.

DevTools: Add support for eventless host message dispatching.

Committed: http://code.google.com/p/v8/source/detail?r=1773

[Søren Thygesen Gjesse, 2009-04-21 15:01:58]

LGTM

You will need to merge with Yurys last change.

http://codereview.chromium.org/87026/diff/16/1011
File src/debug.cc (right):

http://codereview.chromium.org/87026/diff/16/1011#newcode1807
Line 1807: if (!command_received_->Wait(100) &&
Debugger::host_dispatch_handler_) {
I think we should have an V8::Debug API for setting this, also note that this
timeout is in microseconds, not milliseconds as I told you. I think the
V8::Debug API should take milliseconds though.

[pfeldman, 2009-04-22 13:51:48]

http://codereview.chromium.org/87026/diff/16/1011
File src/debug.cc (right):

http://codereview.chromium.org/87026/diff/16/1011#newcode1807
Line 1807: if (!command_received_->Wait(100) &&
Debugger::host_dispatch_handler_) {
On 2009/04/21 15:01:58, Søren Gjesse wrote:
> I think we should have an V8::Debug API for setting this, also note that this
> timeout is in microseconds, not milliseconds as I told you. I think the
> V8::Debug API should take milliseconds though.

Done.

[yurys, 2009-04-22 14:06:08]

http://codereview.chromium.org/87026/diff/4007/3015
File test/cctest/test-debug.cc (left):

http://codereview.chromium.org/87026/diff/4007/3015#oldcode3571
Line 3571: queue.Put(Message::NewHostDispatch(new TestClientData()));
please insert some other messages instead of these so that the queue is still
expanded

http://codereview.chromium.org/87026/diff/4007/3015
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/87026/diff/4007/3015#newcode4238
Line 4238: static char print_buffer[1000];
I think you can safely remove this piece of code

[pfeldman, 2009-04-22 14:08:15]

http://codereview.chromium.org/87026/diff/4007/3015
File test/cctest/test-debug.cc (left):

http://codereview.chromium.org/87026/diff/4007/3015#oldcode3571
Line 3571: queue.Put(Message::NewHostDispatch(new TestClientData()));
On 2009/04/22 14:06:08, Yury Semikhatsky wrote:
> please insert some other messages instead of these so that the queue is still
> expanded

Done.

http://codereview.chromium.org/87026/diff/4007/3015#oldcode3571
Line 3571: queue.Put(Message::NewHostDispatch(new TestClientData()));
On 2009/04/22 14:06:08, Yury Semikhatsky wrote:
> please insert some other messages instead of these so that the queue is still
> expanded

Done.