Issue 87025: Handle breaks on keyed IC loads which can have an inlined version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87025: Handle breaks on keyed IC loads which can have an inlined version (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Handle breaks on keyed IC loads which can have an inlined version. For keyed IC loads setting a break point now ensures that the inlined code is not used. When the break point is set the inlined map check is changed to fail causing the inlined code not to be used but the IC to be called. As long at the break point is set the map check will stay invalid. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1756

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -48 lines)			Patch
M	src/debug.h	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/debug.cc	View	1 2	7 chunks	+67 lines, -44 lines	0 comments	Download
M	src/ic.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic-arm.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ic-ia32.cc	View	1 2	2 chunks	+18 lines, -2 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, thanks for fixing this! http://codereview.chromium.org/87025/diff/1/7 File src/debug.cc (right): http://codereview.chromium.org/87025/diff/1/7#newcode364 Line 364: Remove extra line? ...

11 years, 8 months ago (2009-04-21 14:28:48 UTC) #2

Søren Thygesen Gjesse

11 years, 8 months ago (2009-04-21 14:48:25 UTC) #3

http://codereview.chromium.org/87025/diff/1/7
File src/debug.cc (right):

http://codereview.chromium.org/87025/diff/1/7#newcode364
Line 364: 
On 2009/04/21 14:28:49, Mads Ager wrote:
> Remove extra line?

Done.

http://codereview.chromium.org/87025/diff/1/7#newcode378
Line 378: // is set the patching performed by the runtime system will take palce
in
On 2009/04/21 14:28:49, Mads Ager wrote:
> palce -> place

Done.

Expand Messages | Collapse Messages