Use callback_forward.h instead of callback.h where possible.

callback_forward.h forward-declares base::Callback and base::Closure.

This CL includes callback_forward.h and a number of files that depend on it. Other CLs have been sent to other reviewers, according to OWNERS files. This search shows the other CLs: http://goo.gl/vzQoJ

See this chromium-dev thread for the rationale behind the change: http://goo.gl/I3kob

BUG=None
TEST=Compiles


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111782

[erikwright (departed), 2011-11-26 02:34:50]

Hi Will,

callback_forward.h forward-declares base::Callback and base::Closure.

This CL includes callback_forward.h and a number of files that depend on it.
Other CLs have been sent to other reviewers, according to OWNERS files. This
search shows the other CLs: http://goo.gl/vzQoJ

See this chromium-dev thread for the rationale behind the change:
http://goo.gl/I3kob

[willchan no longer on Chromium, 2011-11-26 03:08:05]

+ajwong

I'll let Albert do the review and then rubberstamp it. I'm in support of the
general change.

[awong, 2011-11-26 08:36:54]

Just got one question.

I'd also bikeshed that the name might want to be callback_decl.h instead of
callback_forward.h, but I don't feel strongly enough to push it at all.

Oh, and can we make callback.h include callback_forward.h?

http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_store_file.h (right):

http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_store_file.h:14: #include
"base/callback.h"
Can't this use forward?

[erikwright (departed), 2011-11-26 18:44:01]

On 2011/11/26 08:36:54, awong wrote:
> Just got one question.
> 
> I'd also bikeshed that the name might want to be callback_decl.h instead of
> callback_forward.h, but I don't feel strongly enough to push it at all.

I debated _forward (as suggested in the thread, and apparently used by WebKit)
and _fwd (as used by C++ std library and, it turns out, XUL). I haven't seen a
precedent for decl, though I'm largely indifferent.

Changing it is not a big hassle, so just let me know what you think makes the
most sense.

> Oh, and can we make callback.h include callback_forward.h?


Yes, will do.

> 
>
http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/sa...
> File chrome/browser/safe_browsing/safe_browsing_store_file.h (right):
> 
>
http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/sa...
> chrome/browser/safe_browsing/safe_browsing_store_file.h:14: #include
> "base/callback.h"
> Can't this use forward?

[erikwright (departed), 2011-11-26 18:44:30]

http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_store_file.h (right):

http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_store_file.h:14: #include
"base/callback.h"
On 2011/11/26 08:36:55, awong wrote:
> Can't this use forward?

No, there is a member Closure.

[awong, 2011-11-26 23:15:44]

LGTM

Thanks for doing this!

On Sat, Nov 26, 2011 at 10:44 AM, <erikwright@chromium.org> wrote:

>
> http://codereview.chromium.**org/8702019/diff/1/chrome/**
>
browser/safe_browsing/safe_**browsing_store_file.h<http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/safe_browsing_store_file.h>
> File chrome/browser/safe_browsing/**safe_browsing_store_file.h (right):
>
> http://codereview.chromium.**org/8702019/diff/1/chrome/**
>
browser/safe_browsing/safe_**browsing_store_file.h#**newcode14<http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/safe_browsing_store_file.h#newcode14>
> chrome/browser/safe_browsing/**safe_browsing_store_file.h:14: #include
> "base/callback.h"
> On 2011/11/26 08:36:55, awong wrote:
>
>> Can't this use forward?
>>
>
> No, there is a member Closure.
>
>
http://codereview.chromium.**org/8702019/<http://codereview.chromium.org/8702...
>

[willchan no longer on Chromium, 2011-11-26 23:22:29]

Stop working so hard :) I'll skim this later tonight and then rubberstamp
it.

On Sat, Nov 26, 2011 at 3:15 PM, Albert J. Wong (王重傑)
<ajwong@chromium.org>wrote:

> LGTM
>
> Thanks for doing this!
>
>
> On Sat, Nov 26, 2011 at 10:44 AM, <erikwright@chromium.org> wrote:
>
>>
>> http://codereview.chromium.**org/8702019/diff/1/chrome/**
>>
browser/safe_browsing/safe_**browsing_store_file.h<http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/safe_browsing_store_file.h>
>> File chrome/browser/safe_browsing/**safe_browsing_store_file.h (right):
>>
>> http://codereview.chromium.**org/8702019/diff/1/chrome/**
>>
browser/safe_browsing/safe_**browsing_store_file.h#**newcode14<http://codereview.chromium.org/8702019/diff/1/chrome/browser/safe_browsing/safe_browsing_store_file.h#newcode14>
>> chrome/browser/safe_browsing/**safe_browsing_store_file.h:14: #include
>> "base/callback.h"
>> On 2011/11/26 08:36:55, awong wrote:
>>
>>> Can't this use forward?
>>>
>>
>> No, there is a member Closure.
>>
>>
http://codereview.chromium.**org/8702019/<http://codereview.chromium.org/8702...
>>
>
>

[willchan no longer on Chromium, 2011-11-28 20:13:07]

lgtm

http://codereview.chromium.org/8702019/diff/1/chrome/browser/automation/ui_co...
File chrome/browser/automation/ui_controls_internal.cc (right):

http://codereview.chromium.org/8702019/diff/1/chrome/browser/automation/ui_co...
chrome/browser/automation/ui_controls_internal.cc:5: #include "base/callback.h"
This should go below the other include. foo.cc needs to include foo.h first.

[commit-bot: I haz the power, 2011-11-28 20:22:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikwright@chromium.org/8702019/13001

[erikwright (departed), 2011-11-28 20:23:08]

http://codereview.chromium.org/8702019/diff/1/chrome/browser/automation/ui_co...
File chrome/browser/automation/ui_controls_internal.cc (right):

http://codereview.chromium.org/8702019/diff/1/chrome/browser/automation/ui_co...
chrome/browser/automation/ui_controls_internal.cc:5: #include "base/callback.h"
On 2011/11/28 20:13:07, willchan wrote:
> This should go below the other include. foo.cc needs to include foo.h first.

Done.

[commit-bot: I haz the power, 2011-11-28 22:00:32]

Change committed as 111782